diff options
| author | jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-05 02:07:34 +0000 |
|---|---|---|
| committer | jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-05 02:07:34 +0000 |
| commit | 13b1e0b71563b8df5a250a5828cfe7c146d245c7 (patch) | |
| tree | 9d542591d873ad72699a8a1a264e23ce2d3616c9 | |
| parent | 70eee34d2d158dc51086b9571e62a61ace16727b (diff) | |
| download | chromium_src-13b1e0b71563b8df5a250a5828cfe7c146d245c7.zip chromium_src-13b1e0b71563b8df5a250a5828cfe7c146d245c7.tar.gz chromium_src-13b1e0b71563b8df5a250a5828cfe7c146d245c7.tar.bz2 | |
Remove some DCHECK/NOTREACHED from plugin_host.cc that can be hit by valid code
I hit these checks while trying to debug a webpage that happened to include some flash content. These checks don't seem to indicate any bug in chrome and we handle the codepath fine in release, so they just seem like a debugging hindrance.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4514001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65171 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | webkit/glue/plugins/plugin_host.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/webkit/glue/plugins/plugin_host.cc b/webkit/glue/plugins/plugin_host.cc index 6345fb1..2e68dff 100644 --- a/webkit/glue/plugins/plugin_host.cc +++ b/webkit/glue/plugins/plugin_host.cc @@ -34,7 +34,6 @@ using WebKit::WebBindings; // The caller must take a reference if needed. static NPAPI::PluginInstance* FindInstance(NPP id) { if (id == NULL) { - NOTREACHED(); return NULL; } return reinterpret_cast<NPAPI::PluginInstance*>(id->ndata); @@ -338,7 +337,6 @@ static NPError GetURLNotify(NPP id, scoped_refptr<NPAPI::PluginInstance> plugin(FindInstance(id)); if (!plugin.get()) { - NOTREACHED(); return NPERR_GENERIC_ERROR; } @@ -611,7 +609,6 @@ void NPN_InvalidateRect(NPP id, NPRect *invalidRect) { // plug-in can call NPN_ForceRedraw after calling this method. scoped_refptr<NPAPI::PluginInstance> plugin(FindInstance(id)); - DCHECK(plugin.get() != NULL); if (plugin.get() && plugin->webplugin()) { if (invalidRect) { #if defined(OS_WIN) |