diff options
author | bulach@chromium.org <bulach@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-25 15:38:10 +0000 |
---|---|---|
committer | bulach@chromium.org <bulach@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-25 15:38:10 +0000 |
commit | 1ca6199521f472a2baac815884fc935f1cc7c92f (patch) | |
tree | c075e3a8cfcde4407e5b0d53a431970fc553b812 | |
parent | 83faf3da9b8ba721d34befd55368e69d0f398c80 (diff) | |
download | chromium_src-1ca6199521f472a2baac815884fc935f1cc7c92f.zip chromium_src-1ca6199521f472a2baac815884fc935f1cc7c92f.tar.gz chromium_src-1ca6199521f472a2baac815884fc935f1cc7c92f.tar.bz2 |
Use iostream instead of StringPrintF for OnAddMessageToConsole.
The "%ls" (wide string) format specifier isn't supported on all platforms.
Rather than converting the strings to utf8, then formatting, just print
them directly to the log stream.
(landing on behalf of husky@google.com, from http://codereview.chromium.org/6725028/)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6736026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79402 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | content/browser/renderer_host/render_view_host.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/content/browser/renderer_host/render_view_host.cc b/content/browser/renderer_host/render_view_host.cc index 9ebbaea..40792b1 100644 --- a/content/browser/renderer_host/render_view_host.cc +++ b/content/browser/renderer_host/render_view_host.cc @@ -1252,9 +1252,8 @@ void RenderViewHost::OnTakeFocus(bool reverse) { void RenderViewHost::OnAddMessageToConsole(const std::wstring& message, int32 line_no, const std::wstring& source_id) { - std::wstring msg = StringPrintf(L"\"%ls,\" source: %ls (%d)", message.c_str(), - source_id.c_str(), line_no); - logging::LogMessage("CONSOLE", 0).stream() << msg; + logging::LogMessage("CONSOLE", 0).stream() << "\"" << message + << ",\" source: " << source_id << " (" << line_no << ")"; } void RenderViewHost::OnForwardToDevToolsAgent(const IPC::Message& message) { |