diff options
| author | hamaji@chromium.org <hamaji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-16 00:48:32 +0000 |
|---|---|---|
| committer | hamaji@chromium.org <hamaji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-16 00:48:32 +0000 |
| commit | 26ff25e5aa52a060e93783c654ae0829f576cea1 (patch) | |
| tree | 55c201c958d1943504fd8bb56514623b4219cb6a | |
| parent | b6e38ef007bf29a33a35dc96d21a5499d42428a3 (diff) | |
| download | chromium_src-26ff25e5aa52a060e93783c654ae0829f576cea1.zip chromium_src-26ff25e5aa52a060e93783c654ae0829f576cea1.tar.gz chromium_src-26ff25e5aa52a060e93783c654ae0829f576cea1.tar.bz2 | |
Add comments on magic number 0xbb. They are VK_OEM_PLUS. I guess the original author of this code considered the case where VK_OEM_PLUS isn't defined. For example, it seems that 0xbb is VK_EQUAL for embeded environments and VK_OEM_PLUS is never defined.
Review URL: http://codereview.chromium.org/119154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18467 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_edit_view_win.cc | 5 | ||||
| -rw-r--r-- | views/controls/textfield/native_textfield_win.cc | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc index 0bc4f6c..5cc2662 100644 --- a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc +++ b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc @@ -907,7 +907,8 @@ bool AutocompleteEditViewWin::SkipDefaultKeyEventProcessing( return !e.IsAltDown() && e.IsControlDown(); case VK_BACK: - case 0xbb: + case 0xbb: // We don't use VK_OEM_PLUS in case the macro isn't defined. + // (e.g., we don't have this symbol in embeded environment). return true; default: @@ -1815,6 +1816,8 @@ bool AutocompleteEditViewWin::OnKeyDownOnlyWritable(TCHAR key, } case 0xbb: // Ctrl-'='. Triggers subscripting (even in plain text mode). + // We don't use VK_OEM_PLUS in case the macro isn't defined. + // (e.g., we don't have this symbol in embeded environment). return true; default: diff --git a/views/controls/textfield/native_textfield_win.cc b/views/controls/textfield/native_textfield_win.cc index 65c6b53..1ccf651 100644 --- a/views/controls/textfield/native_textfield_win.cc +++ b/views/controls/textfield/native_textfield_win.cc @@ -446,6 +446,8 @@ void NativeTextfieldWin::OnKeyDown(TCHAR key, UINT repeat_count, UINT flags) { return; case 0xbb: // Ctrl-'='. Triggers subscripting, even in plain text mode. + // We don't use VK_OEM_PLUS in case the macro isn't defined. + // (e.g., we don't have this symbol in embeded environment). return; case VK_PROCESSKEY: |