diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-19 23:50:00 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-19 23:50:00 +0000 |
commit | 2a9d601b66de546afaaa4f5aedaf2c26bfb21020 (patch) | |
tree | 1dd0f60870ef1b6c99444f58b7334216000c0044 | |
parent | 6504ccb162e1fa1776cf20c466a9e9e71ada827f (diff) | |
download | chromium_src-2a9d601b66de546afaaa4f5aedaf2c26bfb21020.zip chromium_src-2a9d601b66de546afaaa4f5aedaf2c26bfb21020.tar.gz chromium_src-2a9d601b66de546afaaa4f5aedaf2c26bfb21020.tar.bz2 |
Covert LOG(INFO) to VLOG(1) - ipc/.
This also eliminates IPC_MESSAGE_DEBUG_EXTRA and uses VLOG(2) for that.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3889002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63142 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | ipc/ipc_channel_posix.cc | 22 | ||||
-rw-r--r-- | ipc/ipc_channel_win.cc | 26 | ||||
-rw-r--r-- | ipc/ipc_logging.cc | 6 | ||||
-rw-r--r-- | ipc/ipc_sync_channel_unittest.cc | 9 |
4 files changed, 23 insertions, 40 deletions
diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc index 3dded13..86d1673 100644 --- a/ipc/ipc_channel_posix.cc +++ b/ipc/ipc_channel_posix.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -684,10 +684,8 @@ bool Channel::ChannelImpl::ProcessIncomingMessages() { &fds[fds_i], m.header()->num_fds); fds_i += m.header()->num_fds; } -#ifdef IPC_MESSAGE_DEBUG_EXTRA - DLOG(INFO) << "received message on channel @" << this << - " with type " << m.type(); -#endif + DVLOG(2) << "received message on channel @" << this + << " with type " << m.type(); if (m.routing_id() == MSG_ROUTING_NONE && m.type() == HELLO_MESSAGE_TYPE) { // The Hello message contains only the process id. @@ -906,10 +904,8 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages() { message_send_bytes_written_ = 0; // Message sent OK! -#ifdef IPC_MESSAGE_DEBUG_EXTRA - DLOG(INFO) << "sent message @" << msg << " on channel @" << this << - " with type " << msg->type(); -#endif + DVLOG(2) << "sent message @" << msg << " on channel @" << this + << " with type " << msg->type(); delete output_queue_.front(); output_queue_.pop(); } @@ -918,11 +914,9 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages() { } bool Channel::ChannelImpl::Send(Message* message) { -#ifdef IPC_MESSAGE_DEBUG_EXTRA - DLOG(INFO) << "sending message @" << message << " on channel @" << this - << " with type " << message->type() - << " (" << output_queue_.size() << " in queue)"; -#endif + DVLOG(2) << "sending message @" << message << " on channel @" << this + << " with type " << message->type() + << " (" << output_queue_.size() << " in queue)"; #ifdef IPC_MESSAGE_LOG_ENABLED Logging::current()->OnSendMessage(message, ""); diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc index 0470072..31d1d185 100644 --- a/ipc/ipc_channel_win.cc +++ b/ipc/ipc_channel_win.cc @@ -147,11 +147,9 @@ void Channel::ChannelImpl::Close() { bool Channel::ChannelImpl::Send(Message* message) { DCHECK(thread_check_->CalledOnValidThread()); -#ifdef IPC_MESSAGE_DEBUG_EXTRA - DLOG(INFO) << "sending message @" << message << " on channel @" << this - << " with type " << message->type() - << " (" << output_queue_.size() << " in queue)"; -#endif + DVLOG(2) << "sending message @" << message << " on channel @" << this + << " with type " << message->type() + << " (" << output_queue_.size() << " in queue)"; #ifdef IPC_MESSAGE_LOG_ENABLED Logging::current()->OnSendMessage(message, ""); @@ -360,10 +358,8 @@ bool Channel::ChannelImpl::ProcessIncomingMessages( if (message_tail) { int len = static_cast<int>(message_tail - p); const Message m(p, len); -#ifdef IPC_MESSAGE_DEBUG_EXTRA - DLOG(INFO) << "received message on channel @" << this << - " with type " << m.type(); -#endif + DVLOG(2) << "received message on channel @" << this + << " with type " << m.type(); if (m.routing_id() == MSG_ROUTING_NONE && m.type() == HELLO_MESSAGE_TYPE) { // The Hello message contains only the process id. @@ -425,10 +421,8 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages( if (err == ERROR_IO_PENDING) { output_state_.is_pending = true; -#ifdef IPC_MESSAGE_DEBUG_EXTRA - DLOG(INFO) << "sent pending message @" << m << " on channel @" << - this << " with type " << m->type(); -#endif + DVLOG(2) << "sent pending message @" << m << " on channel @" << this + << " with type " << m->type(); return true; } @@ -436,10 +430,8 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages( return false; } -#ifdef IPC_MESSAGE_DEBUG_EXTRA - DLOG(INFO) << "sent message @" << m << " on channel @" << this << - " with type " << m->type(); -#endif + DVLOG(2) << "sent message @" << m << " on channel @" << this + << " with type " << m->type(); output_state_.is_pending = true; return true; diff --git a/ipc/ipc_logging.cc b/ipc/ipc_logging.cc index da857ec..905f097 100644 --- a/ipc/ipc_logging.cc +++ b/ipc/ipc_logging.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -171,8 +171,8 @@ void Logging::GetMessageText(uint32 type, std::string* name, if (log_function_mapping_[message_class] != NULL) { log_function_mapping_[message_class](type, name, message, params); } else { - DLOG(INFO) << "No logger function associated with message class " << - message_class; + DVLOG(1) << "No logger function associated with message class " + << message_class; } } diff --git a/ipc/ipc_sync_channel_unittest.cc b/ipc/ipc_sync_channel_unittest.cc index e01cc58..ffd2efd 100644 --- a/ipc/ipc_sync_channel_unittest.cc +++ b/ipc/ipc_sync_channel_unittest.cc @@ -708,10 +708,8 @@ class QueuedReplyServer : public Worker { } virtual void OnNestedTestMsg(Message* reply_msg) { - LOG(INFO) << __FUNCTION__ << " Sending reply: " - << reply_text_.c_str(); - SyncChannelNestedTestMsg_String::WriteReplyParams( - reply_msg, reply_text_); + VLOG(1) << __FUNCTION__ << " Sending reply: " << reply_text_; + SyncChannelNestedTestMsg_String::WriteReplyParams(reply_msg, reply_text_); Send(reply_msg); Done(); } @@ -747,8 +745,7 @@ class QueuedReplyClient : public Worker { DCHECK(result); DCHECK_EQ(response, expected_text_); - LOG(INFO) << __FUNCTION__ << " Received reply: " - << response.c_str(); + VLOG(1) << __FUNCTION__ << " Received reply: " << response; Done(); } |