summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrohitrao@chromium.org <rohitrao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-24 21:45:17 +0000
committerrohitrao@chromium.org <rohitrao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-09-24 21:45:17 +0000
commit4d5bfc090b95c6f1f87200f27989c4f1fdb4fd5e (patch)
tree3edc4b8522f304d46b0260cadde7fab0a309aed9
parenteb61a66ae7d05c0e1d64715f2e7bf66b1159ad5c (diff)
downloadchromium_src-4d5bfc090b95c6f1f87200f27989c4f1fdb4fd5e.zip
chromium_src-4d5bfc090b95c6f1f87200f27989c4f1fdb4fd5e.tar.gz
chromium_src-4d5bfc090b95c6f1f87200f27989c4f1fdb4fd5e.tar.bz2
[Mac] Support option-return to open in new foreground tab.
BUG=http://crbug.com/22882 TEST=Type something into the omnibox. Option-return should open it in a new foreground tab. TEST=After using Option-return to open something in a new foreground tab, switch back to the original tab and verify that the url in the omnibox has reverted to the original page's url. TEST=Option-leftclick on a link in a webpage should still prompt you to "save as." Review URL: http://codereview.chromium.org/218032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27127 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/autocomplete/autocomplete_edit_view_mac.mm4
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm b/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
index ed26081..e81d0fe 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
@@ -804,9 +804,9 @@ std::wstring AutocompleteEditViewMac::GetClipboardText(Clipboard* clipboard) {
return YES;
}
- // TODO(shess): Option-return, would normally insert a literal
- // newline. Consider combining with -insertNewline:.
+ // Option-Return
if (cmd == @selector(insertNewlineIgnoringFieldEditor:)) {
+ edit_view_->AcceptInput(NEW_FOREGROUND_TAB, false);
return YES;
}