diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-24 21:15:53 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-24 21:15:53 +0000 |
| commit | 5279114bd068ec8a0d31a2c555975f758c295cbc (patch) | |
| tree | ce8c8dfc73386a104b8d503d4cc622622a9a26dc | |
| parent | cb6ea905a6bf438106fa8cadc42345a6423feb2b (diff) | |
| download | chromium_src-5279114bd068ec8a0d31a2c555975f758c295cbc.zip chromium_src-5279114bd068ec8a0d31a2c555975f758c295cbc.tar.gz chromium_src-5279114bd068ec8a0d31a2c555975f758c295cbc.tar.bz2 | |
views/gtk: Set the tooltip text for tab strip and new tab button.
BUG=25442
TEST=hover the mouse through either the tab strip close button or the new tab button, see if a tooltip appears.
Patch by Thiago Farina
original review: http://codereview.chromium.org/669246
Review URL: http://codereview.chromium.org/1254002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42535 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/app/generated_resources.grd | 3 | ||||
| -rw-r--r-- | chrome/browser/gtk/tabs/tab_renderer_gtk.cc | 3 | ||||
| -rw-r--r-- | chrome/browser/views/tabs/tab.cc | 1 |
3 files changed, 7 insertions, 0 deletions
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd index 8e137b4..7406d69 100644 --- a/chrome/app/generated_resources.grd +++ b/chrome/app/generated_resources.grd @@ -3669,6 +3669,9 @@ Keep your key file in a safe place. You will need it to create new versions of y <message name="IDS_TOOLTIP_STOP" desc="The tooltip for the stop button"> Stop loading this page </message> + <message name="IDS_TOOLTIP_CLOSE_TAB" desc="The tooltip for the close tab button"> + Close + </message> <!--Accessible name/action strings--> <message name="IDS_ACCACTION_PRESS" desc="The accessible default action for a button."> diff --git a/chrome/browser/gtk/tabs/tab_renderer_gtk.cc b/chrome/browser/gtk/tabs/tab_renderer_gtk.cc index 16a823d..ef1df93 100644 --- a/chrome/browser/gtk/tabs/tab_renderer_gtk.cc +++ b/chrome/browser/gtk/tabs/tab_renderer_gtk.cc @@ -968,6 +968,9 @@ CustomDrawButton* TabRendererGtk::MakeCloseButton() { CustomDrawButton* button = new CustomDrawButton(IDR_TAB_CLOSE, IDR_TAB_CLOSE_P, IDR_TAB_CLOSE_H, IDR_TAB_CLOSE); + gtk_widget_set_tooltip_text(button->widget(), + l10n_util::GetStringUTF8(IDS_TOOLTIP_CLOSE_TAB).c_str()); + g_signal_connect(button->widget(), "clicked", G_CALLBACK(OnCloseButtonClicked), this); g_signal_connect(button->widget(), "button-release-event", diff --git a/chrome/browser/views/tabs/tab.cc b/chrome/browser/views/tabs/tab.cc index ee08bdd..3d0f422 100644 --- a/chrome/browser/views/tabs/tab.cc +++ b/chrome/browser/views/tabs/tab.cc @@ -107,6 +107,7 @@ Tab::Tab(TabDelegate* delegate) : TabRenderer(), delegate_(delegate), closing_(false) { + close_button()->SetTooltipText(l10n_util::GetString(IDS_TOOLTIP_CLOSE_TAB)); close_button()->SetAccessibleName(l10n_util::GetString(IDS_ACCNAME_CLOSE)); close_button()->SetAnimationDuration(0); SetContextMenuController(this); |