diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-27 06:10:21 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-27 06:10:21 +0000 |
| commit | 5a53b62b3e52202f530447f4fdf3637e39a56c35 (patch) | |
| tree | d07a229448eabf7cc2af642e007b0a62f7d07766 | |
| parent | 754e338262de0671f7d3e09f54008a502674f2bc (diff) | |
| download | chromium_src-5a53b62b3e52202f530447f4fdf3637e39a56c35.zip chromium_src-5a53b62b3e52202f530447f4fdf3637e39a56c35.tar.gz chromium_src-5a53b62b3e52202f530447f4fdf3637e39a56c35.tar.bz2 | |
Fix a layout issue in the input method list in the language options on Chrome
Before the fix, we didn't have any space between a checkbox and the input
method name, which looked bad.
Note that we don't have this problem in other options pages, as our HTML
files are formatted like:
<input id="foobar" type="checkbox">
<span i18n-content="foobar">
the line break between two elements make a text node of a single space
inbetween.
BUG=chromium-os:11248
TEST=on chrome os, open the language options, see the input method list.
Review URL: http://codereview.chromium.org/6241016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72765 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/resources/options/language_options.js | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/browser/resources/options/language_options.js b/chrome/browser/resources/options/language_options.js index 9f6e793..13a1d52 100644 --- a/chrome/browser/resources/options/language_options.js +++ b/chrome/browser/resources/options/language_options.js @@ -136,7 +136,10 @@ cr.define('options', function() { this.handleCheckboxClick_.bind(this)); var label = document.createElement('label'); label.appendChild(input); - label.appendChild(document.createTextNode(inputMethod.displayName)); + // Adding a space between the checkbox and the text. This is a bit + // dirty, but we rely on a space character for all other checkboxes. + label.appendChild(document.createTextNode( + ' ' + inputMethod.displayName)); label.style.display = 'none'; label.languageCodeSet = inputMethod.languageCodeSet; // Add the configure button if the config page is present for this |