diff options
| author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-03 19:06:32 +0000 |
|---|---|---|
| committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-03 19:06:32 +0000 |
| commit | 7035d391e8d13ccabe3bdf47c2faf4d8af8db24f (patch) | |
| tree | 3c8280252c6d9edadf4e398f7b53dab800ffc547 | |
| parent | 9ad436ba75c4b94ad2eb489a43fdab1711eef051 (diff) | |
| download | chromium_src-7035d391e8d13ccabe3bdf47c2faf4d8af8db24f.zip chromium_src-7035d391e8d13ccabe3bdf47c2faf4d8af8db24f.tar.gz chromium_src-7035d391e8d13ccabe3bdf47c2faf4d8af8db24f.tar.bz2 | |
Fix valgrind error in unittests.
A pointer to a stack allocated buffer was being kept around. The buffer should
be static.
BUG=49404
TEST=net_unittests
http://codereview.chromium.org/3005052/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54792 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | net/http/http_auth_handler_negotiate_unittest.cc | 2 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 12 |
2 files changed, 1 insertions, 13 deletions
diff --git a/net/http/http_auth_handler_negotiate_unittest.cc b/net/http/http_auth_handler_negotiate_unittest.cc index 7bcf37c..3d331fc 100644 --- a/net/http/http_auth_handler_negotiate_unittest.cc +++ b/net/http/http_auth_handler_negotiate_unittest.cc @@ -52,7 +52,7 @@ class HttpAuthHandlerNegotiateTest : public PlatformTest { L"Negotiate", SEC_E_OK, security_package_.get()); #elif defined(OS_POSIX) // Copied from an actual transaction! - const char kAuthResponse[] = + static const char kAuthResponse[] = "\x60\x82\x02\xCA\x06\x09\x2A\x86\x48\x86\xF7\x12\x01\x02\x02\x01" "\x00\x6E\x82\x02\xB9\x30\x82\x02\xB5\xA0\x03\x02\x01\x05\xA1\x03" "\x02\x01\x0E\xA2\x07\x03\x05\x00\x00\x00\x00\x00\xA3\x82\x01\xC1" diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index be1785e..8393609 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -3569,18 +3569,6 @@ fun:_ZN3net46HttpAuthHandlerNegotiateTest_DisableCname_Test8TestBodyEv } { - bug_49404c - Memcheck:Value4 - fun:modp_b64_encode - fun:_ZN4base12Base64EncodeERKSsPSs - fun:_ZN3net14HttpAuthGSSAPI17GenerateAuthTokenEPKSbItN4base20string16_char_traitsESaItEES6_RKSbIwSt11char_traitsIwESaIwEEPSs - ... - fun:_ZN3net24HttpAuthHandlerNegotiate6DoLoopEi - fun:_ZN3net24HttpAuthHandlerNegotiate21GenerateAuthTokenImplEPKSbItN4base20string16_char_traitsESaItEES6_PKNS_15HttpRequestInfoEP14CallbackRunnerI6Tuple1IiEEPSs - fun:_ZN3net15HttpAuthHandler17GenerateAuthTokenEPKSbItN4base20string16_char_traitsESaItEES6_PKNS_15HttpRequestInfoEP14CallbackRunnerI6Tuple1IiEEPSs - fun:_ZN3net46HttpAuthHandlerNegotiateTest_DisableCname_Test8TestBodyEv -} -{ bug_50056 Memcheck:Leak fun:_Znw* |