diff options
| author | craig.schlenter@chromium.org <craig.schlenter@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-22 15:11:21 +0000 |
|---|---|---|
| committer | craig.schlenter@chromium.org <craig.schlenter@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-22 15:11:21 +0000 |
| commit | 711242a5430ff9c0a6498dd372807ba1771df5f8 (patch) | |
| tree | d2825fcb4272a0dbb884194c9bc81d66ed70eddc | |
| parent | 0816b0a9f376027797d4879988bbd1afc2967a39 (diff) | |
| download | chromium_src-711242a5430ff9c0a6498dd372807ba1771df5f8.zip chromium_src-711242a5430ff9c0a6498dd372807ba1771df5f8.tar.gz chromium_src-711242a5430ff9c0a6498dd372807ba1771df5f8.tar.bz2 | |
Linux: correctly handle single byte value for NPPVpluginNeedsXEmbed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/650135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39596 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | webkit/glue/plugins/webplugin_delegate_impl_gtk.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc index 3e4f607..2f0948b 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc +++ b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc @@ -116,9 +116,9 @@ bool WebPluginDelegateImpl::WindowedCreatePlugin() { DCHECK(!windowed_handle_); DCHECK(!plug_); - // NPP_GetValue() will write 4 bytes of data to this variable. Don't use a - // single byte bool, use an int instead. - int xembed; + // NPP_GetValue() might write 4 bytes of data to this variable. Don't use a + // single byte bool, use an int instead and make sure it is initialized. + int xembed = 0; NPError err = instance_->NPP_GetValue(NPPVpluginNeedsXEmbed, &xembed); if (err != NPERR_NO_ERROR || !xembed) { NOTIMPLEMENTED() << " windowed plugin but without xembed."; |