diff options
author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-14 18:19:52 +0000 |
---|---|---|
committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-14 18:19:52 +0000 |
commit | 8ab7b0ec38a97646397298877a61c44ab122102f (patch) | |
tree | fe34de9a40a14943b09340a05cb916a7ef929fc9 | |
parent | 4c21b0f14edcb3bfc2c5c481428fe71bb9107817 (diff) | |
download | chromium_src-8ab7b0ec38a97646397298877a61c44ab122102f.zip chromium_src-8ab7b0ec38a97646397298877a61c44ab122102f.tar.gz chromium_src-8ab7b0ec38a97646397298877a61c44ab122102f.tar.bz2 |
Get Mac ui valgrind greener.
I am able to "remove" these valgrind errors with some contortions in
the code but don't think it's worth it.
BUG=none
TEST=greener tree
Review URL: http://codereview.chromium.org/2313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52353 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | tools/valgrind/memcheck/suppressions_mac.txt | 36 |
1 files changed, 36 insertions, 0 deletions
diff --git a/tools/valgrind/memcheck/suppressions_mac.txt b/tools/valgrind/memcheck/suppressions_mac.txt index d78e8c9..9c2b5b0 100644 --- a/tools/valgrind/memcheck/suppressions_mac.txt +++ b/tools/valgrind/memcheck/suppressions_mac.txt @@ -208,6 +208,42 @@ fun:_dyld_start obj:* } +{ + # jrg thinks this is probably a bug in Cocoa but is harmless. We + # can hit it by using --homepage=about:blank, which triggers a + # location bar focus earlier than normal (earlier than when a + # window is shown). To "work around" the problem for valgrind, we + # could call for example call [NSWindow setInitialFirstResponder:] + # instead of [NSWindow makeFirstResponder:] if the window isn't + # visible. However, these contortions are ugly. since the + # needsDisplay region gets reset when the window is shown, it + # really doesn't matter what we do with it before then. + Memcheck:Cond + fun:NSIsEmptyRect + fun:-[NSRegion isEmpty] + fun:-[NSRegion subtractRegion:] + fun:-[NSWindow _subtractFromNeedsDisplayRegion:] + ... + fun:-[NSWindow makeKeyAndOrderFront:] + fun:_ZN18BrowserWindowCocoa4ShowEv + ... + fun:_ZN11BrowserInit17LaunchWithProfile17OpenURLsInBrowserEP7BrowserbRKSt6vectorI4GURLSaIS4_EE + ... + fun:ChromeMain + fun:main +} +{ + # Same as above -- touching a region we'll throw away soon. + Memcheck:Cond + fun:NSUnionRect + fun:-[NSRegion addRect:] + ... + fun:-[AutocompleteTextField becomeFirstResponder] + fun:-[NSWindow makeFirstResponder:] + fun:_ZN23AutocompleteEditViewMac13FocusLocationEb + ... + fun:_ZN13TabStripModel14AddTabContentsEP11TabContentsiji +} # 3. Suppressions for real chromium bugs that are not yet fixed. { |