summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-02 20:15:25 +0000
committerojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-02 20:15:25 +0000
commit9e0dfa8ae69f71441d62f725441f7075f791bd09 (patch)
tree20a35be4947f2bb2bdcded4807463ea2226d8422
parentb9e2ecab97a8a7f3cce06951ab92a3eaef559206 (diff)
downloadchromium_src-9e0dfa8ae69f71441d62f725441f7075f791bd09.zip
chromium_src-9e0dfa8ae69f71441d62f725441f7075f791bd09.tar.gz
chromium_src-9e0dfa8ae69f71441d62f725441f7075f791bd09.tar.bz2
Move the check for hiding tests in the cross-builder view up
one level and have it use the passed-in boolean instead of currentState.tests since we can now view the tests in cross-builder view in a popup on the single-builder view. Review URL: http://codereview.chromium.org/255063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27888 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--webkit/tools/layout_tests/flakiness_dashboard.html10
1 files changed, 3 insertions, 7 deletions
diff --git a/webkit/tools/layout_tests/flakiness_dashboard.html b/webkit/tools/layout_tests/flakiness_dashboard.html
index f74a8c5..ab950cb 100644
--- a/webkit/tools/layout_tests/flakiness_dashboard.html
+++ b/webkit/tools/layout_tests/flakiness_dashboard.html
@@ -1023,14 +1023,8 @@
/**
* Returns whether we should exclude test results from the test table.
- * Note that we never want to exclude tests when we're in the individual
- * tests view of the dashboard since the user is explicitly listing tests
- * to view.
*/
function shouldHideTest(testResult) {
- if (currentState.tests)
- return false;
-
if (testResult.isWontFix && !currentState.showWontFix)
return true;
@@ -1057,9 +1051,11 @@
}
function getHTMLForSingleTestRow(test, builder, opt_isCrossBuilderView) {
- if (shouldHideTest(test)) {
+ if (!opt_isCrossBuilderView && shouldHideTest(test)) {
// The innerHTML call is considerably faster if we exclude the rows for
// items we're not showing than if we hide them using display:none.
+ // For the crossBuilderView, we want to show all rows the user is
+ // explicitly listing tests to view.
return '';
}