diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-12 10:19:40 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-12 10:19:40 +0000 |
commit | a15236494feb1f18676d53d121b0c5499ce92c3d (patch) | |
tree | 94fdaa0411cee0648ac62740956ba5711d4a6b0f | |
parent | 8eb8c1a5e468df88c503f59bd3034938aeb1136a (diff) | |
download | chromium_src-a15236494feb1f18676d53d121b0c5499ce92c3d.zip chromium_src-a15236494feb1f18676d53d121b0c5499ce92c3d.tar.gz chromium_src-a15236494feb1f18676d53d121b0c5499ce92c3d.tar.bz2 |
Uninitialized member vars and inlined constructors.
BUG=None
TEST=None
CID=3810, 8793, 8794
Review URL: http://codereview.chromium.org/3156003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55869 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | net/http/http_auth.h | 6 | ||||
-rw-r--r-- | net/http/http_auth_cache.cc | 4 | ||||
-rw-r--r-- | net/http/http_auth_cache.h | 2 | ||||
-rw-r--r-- | net/http/http_auth_handler_digest.cc | 10 | ||||
-rw-r--r-- | net/http/http_auth_handler_digest.h | 5 |
5 files changed, 22 insertions, 5 deletions
diff --git a/net/http/http_auth.h b/net/http/http_auth.h index 542165c..347bdec 100644 --- a/net/http/http_auth.h +++ b/net/http/http_auth.h @@ -121,7 +121,11 @@ class HttpAuth { public: ChallengeTokenizer(std::string::const_iterator begin, std::string::const_iterator end) - : props_(begin, end, ','), valid_(true), begin_(begin), end_(end), + : props_(begin, end, ','), + valid_(true), + begin_(begin), + end_(end), + value_is_quoted_(false), expect_base64_token_(false) { Init(begin, end); } diff --git a/net/http/http_auth_cache.cc b/net/http/http_auth_cache.cc index 58a90f1..5b1a275 100644 --- a/net/http/http_auth_cache.cc +++ b/net/http/http_auth_cache.cc @@ -134,6 +134,10 @@ HttpAuthCache::Entry* HttpAuthCache::Add(const GURL& origin, return entry; } +HttpAuthCache::Entry::Entry() + : nonce_count_(0) { +} + void HttpAuthCache::Entry::AddPath(const std::string& path) { std::string parent_dir = GetParentDirectory(path); if (!HasEnclosingPath(parent_dir)) { diff --git a/net/http/http_auth_cache.h b/net/http/http_auth_cache.h index 423e432..3716646 100644 --- a/net/http/http_auth_cache.h +++ b/net/http/http_auth_cache.h @@ -133,7 +133,7 @@ class HttpAuthCache::Entry { FRIEND_TEST_ALL_PREFIXES(HttpAuthCacheTest, AddPath); FRIEND_TEST_ALL_PREFIXES(HttpAuthCacheTest, AddToExistingEntry); - Entry() {} + Entry(); // Adds a path defining the realm's protection space. If the path is // already contained in the protection space, is a no-op. diff --git a/net/http/http_auth_handler_digest.cc b/net/http/http_auth_handler_digest.cc index c0d04d5..ebb2494 100644 --- a/net/http/http_auth_handler_digest.cc +++ b/net/http/http_auth_handler_digest.cc @@ -87,6 +87,16 @@ std::string HttpAuthHandlerDigest::AlgorithmToString(int algorithm) { } } +HttpAuthHandlerDigest::HttpAuthHandlerDigest(int nonce_count) + : stale_(false), + algorithm_(ALGORITHM_UNSPECIFIED), + qop_(0), + nonce_count_(nonce_count) { +} + +HttpAuthHandlerDigest::~HttpAuthHandlerDigest() { +} + int HttpAuthHandlerDigest::GenerateAuthTokenImpl( const string16* username, const string16* password, diff --git a/net/http/http_auth_handler_digest.h b/net/http/http_auth_handler_digest.h index 777ac3c..ad70ac1 100644 --- a/net/http/http_auth_handler_digest.h +++ b/net/http/http_auth_handler_digest.h @@ -70,9 +70,8 @@ class HttpAuthHandlerDigest : public HttpAuthHandler { QOP_AUTH_INT = 1 << 1, }; - explicit HttpAuthHandlerDigest(int nonce_count) : nonce_count_(nonce_count) {} - - ~HttpAuthHandlerDigest() {} + explicit HttpAuthHandlerDigest(int nonce_count); + ~HttpAuthHandlerDigest(); // Parse the challenge, saving the results into this instance. // Returns true on success. |