diff options
| author | erikkay@google.com <erikkay@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-23 23:25:31 +0000 |
|---|---|---|
| committer | erikkay@google.com <erikkay@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-23 23:25:31 +0000 |
| commit | a38b8719287643f591d4539b43f661008d28bbfd (patch) | |
| tree | e5fc058ed4b6c1b1e7ce8a9d9a0f7477b125345c | |
| parent | d418c9954cc31c077f90712ca26deba70a9179e1 (diff) | |
| download | chromium_src-a38b8719287643f591d4539b43f661008d28bbfd.zip chromium_src-a38b8719287643f591d4539b43f661008d28bbfd.tar.gz chromium_src-a38b8719287643f591d4539b43f661008d28bbfd.tar.bz2 | |
Reverting 7423.
After talking with Darin, I'm convinced this was a bad idea. The issue is that Linux can't actually know the encoding of the file (bad Linux!), so on Linux this method is nonsensical. It also turns out to not be useful for the case I thought I needed it for.
Review URL: http://codereview.chromium.org/16252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7455 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | base/file_path.cc | 9 | ||||
| -rw-r--r-- | base/file_path.h | 4 |
2 files changed, 0 insertions, 13 deletions
diff --git a/base/file_path.cc b/base/file_path.cc index 7cfe952..45f6e327 100644 --- a/base/file_path.cc +++ b/base/file_path.cc @@ -63,15 +63,6 @@ bool IsPathAbsolute(const FilePath::StringType& path) { } // namespace -const std::string FilePath::UTF8Value() const { -#if defined(OS_POSIX) - // TODO(erikkay): I'm not sure how to make this code always correct for Linux. - return path_; -#elif defined(OS_WIN) - return WideToUTF8(path_); -#endif -} - bool FilePath::IsSeparator(CharType character) { for (size_t i = 0; i < arraysize(kSeparators) - 1; ++i) { if (character == kSeparators[i]) { diff --git a/base/file_path.h b/base/file_path.h index 6d57c97..cadf2cf 100644 --- a/base/file_path.h +++ b/base/file_path.h @@ -132,10 +132,6 @@ class FilePath { const StringType& value() const { return path_; } - // Returns value() encoded as a UTF8 std::string. Be careful to not use this - // in places that use filesystem APIs as it won't be portable. - const std::string UTF8Value() const; - // Returns true if |character| is in kSeparators. static bool IsSeparator(CharType character); |