summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-02-23 09:56:52 +0000
committerdarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-02-23 09:56:52 +0000
commita8f4f64eda02ee025cc44f0b89c94954304f93de (patch)
treef1e16e22196c235519fbd27eeb81fbc08361c6fe
parente5cefa0306bf61d671529028adecdb7c68bfb05d (diff)
downloadchromium_src-a8f4f64eda02ee025cc44f0b89c94954304f93de.zip
chromium_src-a8f4f64eda02ee025cc44f0b89c94954304f93de.tar.gz
chromium_src-a8f4f64eda02ee025cc44f0b89c94954304f93de.tar.bz2
Suppress calls to willEnter/didExitModalLoop to avoid deferring resource loads
while querying cookies. This is another attempt to isolate the Intl2 performance regression caused by r39327. TBR=jam BUG=36310 TEST=none Review URL: http://codereview.chromium.org/654002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39706 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/renderer/renderer_webkitclient_impl.cc6
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/renderer/renderer_webkitclient_impl.cc b/chrome/renderer/renderer_webkitclient_impl.cc
index 9a834ea..c15aa96 100644
--- a/chrome/renderer/renderer_webkitclient_impl.cc
+++ b/chrome/renderer/renderer_webkitclient_impl.cc
@@ -131,6 +131,12 @@ WebString RendererWebKitClientImpl::cookies(
// when there is no active script context.
int32 routing_id = RenderThread::RoutingIDForCurrentContext();
+ // TODO(darin): This means that network load completions may run within the
+ // context of a document.cookie call. This violates the "run to completion"
+ // gaurantee of JS. This is just here as a temporary measure to isolate a
+ // performance regression.
+ RenderThread::current()->DoNotNotifyWebKitOfModalLoop();
+
std::string value_utf8;
RenderThread::current()->SendAndRunNestedMessageLoop(
new ViewHostMsg_GetCookies(routing_id, url, first_party_for_cookies,