summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorager@google.com <ager@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-01-15 10:50:26 +0000
committerager@google.com <ager@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-01-15 10:50:26 +0000
commitb2d27cbb0926a997759115f73f221e1f3bb56755 (patch)
treea73924a0766bbf596459d11b9caf554700d18933
parent7d257761656ca0b2ada61e148dbe1c314ecb6ff8 (diff)
downloadchromium_src-b2d27cbb0926a997759115f73f221e1f3bb56755.zip
chromium_src-b2d27cbb0926a997759115f73f221e1f3bb56755.tar.gz
chromium_src-b2d27cbb0926a997759115f73f221e1f3bb56755.tar.bz2
Rebaseline a layout test where only the exception text is different.
Update the test list with information about another test and remove a test that is currently completely disabled. Review URL: http://codereview.chromium.org/18224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8089 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/README4
-rw-r--r--webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/exception-thrown-from-new-expected.txt5
-rw-r--r--webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/README4
-rw-r--r--webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/exception-thrown-from-new-expected.txt5
-rw-r--r--webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/README1
-rw-r--r--webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/exception-thrown-from-new-expected.txt5
-rw-r--r--webkit/tools/layout_tests/test_lists/tests_fixable.txt12
7 files changed, 31 insertions, 5 deletions
diff --git a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/README b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/README
index 8b29133..88a88e1 100644
--- a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/README
+++ b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/README
@@ -16,3 +16,7 @@ function-dot-arguments-and-caller
The only difference is that V8 defines the caller of a custom toString function
as the function that calls toString() on the object. This treatment is
consistent with Firefox.
+
+exception-thrown-from-new
+--------------------------
+Exception text is different in v8
diff --git a/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/exception-thrown-from-new-expected.txt b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/exception-thrown-from-new-expected.txt
new file mode 100644
index 0000000..08f0a04
--- /dev/null
+++ b/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/js/exception-thrown-from-new-expected.txt
@@ -0,0 +1,5 @@
+This page tests exceptions thrown from 'new' expressions. If the test passes, you'll see a series of PASS messages below.
+
+FAIL: e1 should be 'TypeError: Result of expression 'f' [undefined] is not a constructor.' but instead is 'TypeError: undefined is not a constructor'.
+FAIL: e2 should be 'TypeError: Result of expression 'g' [undefined] is not a function.' but instead is 'TypeError: undefined is not a function'.
+
diff --git a/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/README b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/README
index 8b29133..88a88e1 100644
--- a/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/README
+++ b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/README
@@ -16,3 +16,7 @@ function-dot-arguments-and-caller
The only difference is that V8 defines the caller of a custom toString function
as the function that calls toString() on the object. This treatment is
consistent with Firefox.
+
+exception-thrown-from-new
+--------------------------
+Exception text is different in v8
diff --git a/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/exception-thrown-from-new-expected.txt b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/exception-thrown-from-new-expected.txt
new file mode 100644
index 0000000..08f0a04
--- /dev/null
+++ b/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/exception-thrown-from-new-expected.txt
@@ -0,0 +1,5 @@
+This page tests exceptions thrown from 'new' expressions. If the test passes, you'll see a series of PASS messages below.
+
+FAIL: e1 should be 'TypeError: Result of expression 'f' [undefined] is not a constructor.' but instead is 'TypeError: undefined is not a constructor'.
+FAIL: e2 should be 'TypeError: Result of expression 'g' [undefined] is not a function.' but instead is 'TypeError: undefined is not a function'.
+
diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/README b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/README
index c53e088..4f1eef4 100644
--- a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/README
+++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/README
@@ -47,6 +47,7 @@ kde\crash-2-expected.txt
V8 prints "Stack overflow" to console.
cyclic-prototypes-expected.txt
+exception-thrown-from-new
--------------------------
Exception text is different in v8
diff --git a/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/exception-thrown-from-new-expected.txt b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/exception-thrown-from-new-expected.txt
new file mode 100644
index 0000000..08f0a04
--- /dev/null
+++ b/webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/exception-thrown-from-new-expected.txt
@@ -0,0 +1,5 @@
+This page tests exceptions thrown from 'new' expressions. If the test passes, you'll see a series of PASS messages below.
+
+FAIL: e1 should be 'TypeError: Result of expression 'f' [undefined] is not a constructor.' but instead is 'TypeError: undefined is not a constructor'.
+FAIL: e2 should be 'TypeError: Result of expression 'g' [undefined] is not a function.' but instead is 'TypeError: undefined is not a function'.
+
diff --git a/webkit/tools/layout_tests/test_lists/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/tests_fixable.txt
index 476eb39..f41e1c3 100644
--- a/webkit/tools/layout_tests/test_lists/tests_fixable.txt
+++ b/webkit/tools/layout_tests/test_lists/tests_fixable.txt
@@ -1198,11 +1198,14 @@ LINUX : LayoutTests/scrollbars/listbox-scrollbar-combinations.html = FAIL
LINUX WIN : LayoutTests/scrollbars/overflow-scrollbar-combinations.html = FAIL
LINUX : LayoutTests/scrollbars/scrollbar-buttons.html = FAIL
LINUX : LayoutTests/scrollbars/scrollbar-orientation.html = FAIL
-LayoutTests/http/tests/security/MessagePort/event-listener-context.html = FAIL
-// The extra output may be legitimate; the extra setSelectionRange line is
-// printed if that property is on a button. This is either a small problem in
-// test shell or a big problem in V8.
+// The handling of the selection functions on HTMLInputElements differ
+// from the Firefox behavior. We should follow Firefox and I believe
+// that WebKit should as well. I have submitted a patch to fix this
+// upstream after which it will be easy to fix in the v8 bindings as
+// well.
+//
+// https://bugs.webkit.org/show_bug.cgi?id=23300
LayoutTests/fast/forms/selection-functions.html = FAIL
// MERGE REGRESSIONS 36102:37604
@@ -1249,7 +1252,6 @@ chrome/fast/forms/basic-textareas.html = FAIL
LayoutTests/http/tests/misc/dns-prefetch-control.html = FAIL TIMEOUT PASS
// NEW FOR MERGE 37604:38097
LayoutTests/fast/events/destroyed-atomic-string.html = FAIL
-LayoutTests/fast/js/exception-thrown-from-new.html = FAIL
LayoutTests/fast/js/global-constructors.html = FAIL
LINUX WIN : LayoutTests/fast/layers/opacity-transforms.html = FAIL
LayoutTests/fast/profiler = FAIL TIMEOUT