diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-10 15:07:06 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-10 15:07:06 +0000 |
| commit | b58b26560f1c23dc99962f2eba08a371d35a8283 (patch) | |
| tree | f5cf70cf0bb7e209765fbc8e0c19daff3ff07a99 | |
| parent | e1f7b2af64d75ebc8d2c3b836f0af4c75dbf7c7d (diff) | |
| download | chromium_src-b58b26560f1c23dc99962f2eba08a371d35a8283.zip chromium_src-b58b26560f1c23dc99962f2eba08a371d35a8283.tar.gz chromium_src-b58b26560f1c23dc99962f2eba08a371d35a8283.tar.bz2 | |
Removing a TODO in checkdeps. The "check added includes" presubmit
check is only useful for code that is being heavily refactored,
dependencies broken etc. I don't know of any such Java code, and if in
the future this check is needed for Java code, I would expect the
people involved to add it.
BUG=none
R=finnur@chromium.org
Review URL: https://codereview.chromium.org/18295003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210844 0039d316-1c4b-4281-b951-d872f2087c98
| -rwxr-xr-x | tools/checkdeps/checkdeps.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tools/checkdeps/checkdeps.py b/tools/checkdeps/checkdeps.py index 8333ef6..5bfde13 100755 --- a/tools/checkdeps/checkdeps.py +++ b/tools/checkdeps/checkdeps.py @@ -411,7 +411,6 @@ class DepsChecker(object): cpp = cpp_checker.CppChecker(self.verbose) problems = [] for file_path, include_lines in added_includes: - # TODO(joi): Make this cover Java as well. if not cpp.IsCppFile(file_path): pass rules_for_file = self.GetDirectoryRules(os.path.dirname(file_path)) |