diff options
author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-29 17:02:53 +0000 |
---|---|---|
committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-29 17:02:53 +0000 |
commit | bf3952f94423b35aa54bc12184a8ecc54ec1fc33 (patch) | |
tree | 34a5a912989c1f7fde37324f4e9e6e38ed673430 | |
parent | 51baafa73a4c101492f77d36d1c4a9add2a1187d (diff) | |
download | chromium_src-bf3952f94423b35aa54bc12184a8ecc54ec1fc33.zip chromium_src-bf3952f94423b35aa54bc12184a8ecc54ec1fc33.tar.gz chromium_src-bf3952f94423b35aa54bc12184a8ecc54ec1fc33.tar.bz2 |
Rename more IDs on about:net-internals to use hyphens and prefix with view name.
BUG=90857
Review URL: http://codereview.chromium.org/7532033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94696 0039d316-1c4b-4281-b951-d872f2087c98
11 files changed, 98 insertions, 93 deletions
diff --git a/chrome/browser/resources/net_internals/dns_view.html b/chrome/browser/resources/net_internals/dns_view.html index 78cfb49..bb1d31d 100644 --- a/chrome/browser/resources/net_internals/dns_view.html +++ b/chrome/browser/resources/net_internals/dns_view.html @@ -1,26 +1,26 @@ <!-- Host resolver info --> -<div id=dnsTabContent> +<div id=dns-view-tab-content> <h4>Host resolver</h4> <ul> <li><a href='#events&q=type:HOST_RESOLVER_IMPL_REQUEST%20type:HOST_RESOLVER_IMPL_JOB%20is:active'>View pending lookups</a></li> - <li>Default address family: <span id=hostResolverDefaultFamily></span> - <span id=hostResolverIPv6Disabled class=warningText style="display: none;"> + <li>Default address family: <span id=dns-view-default-family></span> + <span id=dns-view-ipv6-disabled class=warningText style="display: none;"> (IPv6 disabled) - <input type=button value="Enable IPv6" id=hostResolverEnableIPv6 /> + <input type=button value="Enable IPv6" id=dns-view-enable-ipv6 /> </span> </li> </ul> <h4> Host resolver cache - <input type=button value="Clear host cache" id=clearHostResolverCache class="hideOnLoadLog" /> + <input type=button value="Clear host cache" id=dns-view-clear-cache class="hideOnLoadLog" /> </h4> <ul> - <li>Capacity: <span id=hostResolverCacheCapacity></span></li> + <li>Capacity: <span id=dns-view-cache-capacity></span></li> <li>Time to live (ms) for success entries: - <span id=hostResolverCacheTTLSuccess></span></li> + <span id=dns-view-cache-ttl-success></span></li> <li>Time to live (ms) for failure entries: - <span id=hostResolverCacheTTLFailure></span></li> + <span id=dns-view-cache-ttl-failure></span></li> </ul> <table class="styledTable"> @@ -32,7 +32,7 @@ <th>Expires</th> </tr> </thead> - <tbody id=hostResolverCacheTbody> + <tbody id=dns-view-cache-tbody> </tbody> </table> </div> diff --git a/chrome/browser/resources/net_internals/dns_view.js b/chrome/browser/resources/net_internals/dns_view.js index ebfcde5..b0fbe90 100644 --- a/chrome/browser/resources/net_internals/dns_view.js +++ b/chrome/browser/resources/net_internals/dns_view.js @@ -14,15 +14,15 @@ * @constructor */ function DnsView() { - const mainBoxId = 'dnsTabContent'; - const cacheTbodyId = 'hostResolverCacheTbody'; - const clearCacheButtonId = 'clearHostResolverCache'; - const defaultFamilySpanId = 'hostResolverDefaultFamily'; - const ipv6DisabledSpanId = 'hostResolverIPv6Disabled'; - const enableIPv6ButtonId = 'hostResolverEnableIPv6'; - const capacitySpanId = 'hostResolverCacheCapacity'; - const ttlSuccessSpanId = 'hostResolverCacheTTLSuccess'; - const ttlFailureSpanId = 'hostResolverCacheTTLFailure'; + const mainBoxId = 'dns-view-tab-content'; + const cacheTbodyId = 'dns-view-cache-tbody'; + const clearCacheButtonId = 'dns-view-clear-cache'; + const defaultFamilySpanId = 'dns-view-default-family'; + const ipv6DisabledSpanId = 'dns-view-ipv6-disabled'; + const enableIPv6ButtonId = 'dns-view-enable-ipv6'; + const capacitySpanId = 'dns-view-cache-capacity'; + const ttlSuccessSpanId = 'dns-view-cache-ttl-success'; + const ttlFailureSpanId = 'dns-view-cache-ttl-failure'; DivView.call(this, mainBoxId); diff --git a/chrome/browser/resources/net_internals/events_view.html b/chrome/browser/resources/net_internals/events_view.html index f22fcca..250efe1 100644 --- a/chrome/browser/resources/net_internals/events_view.html +++ b/chrome/browser/resources/net_internals/events_view.html @@ -5,8 +5,8 @@ <table width=100%> <tr> <td width=1%>Filter:</td> - <td width=98%><input type="search" incremental id=filterInput /></td> - <td width=1% id=filterCount>(1 of 34)</td> + <td width=98%><input type="search" incremental id=events-view-filter-input /></td> + <td width=1% id=events-view-filter-count>(1 of 34)</td> </tr> </table> </div> @@ -15,10 +15,10 @@ <table id=events-view-source-list-table cellspacing=0 cellpadding=0 width=100%> <thead> <tr> - <td><input type=checkbox id=selectAll /></td> - <td id=sortById>ID</td> - <td id=sortBySource>Source</td> - <td id=sortByDescription width=99%>Description</td> + <td><input type=checkbox id=events-view-select-all /></td> + <td id=events-view-sort-by-id>ID</td> + <td id=events-view-sort-by-source>Source</td> + <td id=events-view-sort-by-description width=99%>Description</td> </tr> </thead> <!-- Events table body: This is where request rows go into --> @@ -27,21 +27,21 @@ </div> <!-- Action Box: This is a button bar along the bottom --> <div id=events-view-action-box> - <input type=button value="Delete selected" id=deleteSelected /> - <input type=button value="Delete all" id=deleteAll /> + <input type=button value="Delete selected" id=events-view-delete-selected /> + <input type=button value="Delete all" id=events-view-delete-all /> </div> <!-- Splitter Box: This is a handle to resize the vertical divider --> -<div id=splitterBoxForEventDetails class=vertical-splitter></div> +<div id=events-view-splitter-box class=vertical-splitter></div> <!-- Details box: This is the panel on the right which shows information --> <div id=events-view-details-tab-handles> <table class=events-view-tab-switcher cellspacing=0> <tr> - <th id=detailsLogTab>Log</th> + <th id=events-view-details-log-tab>Log</th> <td> </td> - <th id=detailsTimelineTab>Timeline</th> + <th id=events-view-details-timeline-tab>Timeline</th> </tr> </table> <div class=events-view-tab-switcher-line></div> </div> -<div id=detailsLogBox></div> -<div id=detailsTimelineBox></div> +<div id=events-view-details-log-box></div> +<div id=events-view-details-timeline-box></div> diff --git a/chrome/browser/resources/net_internals/events_view.js b/chrome/browser/resources/net_internals/events_view.js index dda98cc..6065cab 100644 --- a/chrome/browser/resources/net_internals/events_view.js +++ b/chrome/browser/resources/net_internals/events_view.js @@ -27,23 +27,23 @@ */ function EventsView() { const tableBodyId = 'events-view-source-list-tbody'; - const filterInputId = 'filterInput'; - const filterCountId = 'filterCount'; - const deleteSelectedId = 'deleteSelected'; - const deleteAllId = 'deleteAll'; - const selectAllId = 'selectAll'; - const sortByIdId = 'sortById'; - const sortBySourceTypeId = 'sortBySource'; - const sortByDescriptionId = 'sortByDescription'; + const filterInputId = 'events-view-filter-input'; + const filterCountId = 'events-view-filter-count'; + const deleteSelectedId = 'events-view-delete-selected'; + const deleteAllId = 'events-view-delete-all'; + const selectAllId = 'events-view-select-all'; + const sortByIdId = 'events-view-sort-by-id'; + const sortBySourceTypeId = 'events-view-sort-by-source'; + const sortByDescriptionId = 'events-view-sort-by-description'; const tabHandlesContainerId = 'events-view-details-tab-handles'; - const logTabId = 'detailsLogTab'; - const timelineTabId = 'detailsTimelineTab'; - const detailsLogBoxId = 'detailsLogBox'; - const detailsTimelineBoxId = 'detailsTimelineBox'; + const logTabId = 'events-view-details-log-tab'; + const timelineTabId = 'events-view-details-timeline-tab'; + const detailsLogBoxId = 'events-view-details-log-box'; + const detailsTimelineBoxId = 'events-view-details-timeline-box'; const topbarId = 'events-view-filter-box'; const middleboxId = 'events-view-source-list'; const bottombarId = 'events-view-action-box'; - const sizerId = 'splitterBoxForEventDetails'; + const sizerId = 'events-view-splitter-box'; View.call(this); diff --git a/chrome/browser/resources/net_internals/hsts_view.html b/chrome/browser/resources/net_internals/hsts_view.html index 9cbd7fc..3bf52d0 100644 --- a/chrome/browser/resources/net_internals/hsts_view.html +++ b/chrome/browser/resources/net_internals/hsts_view.html @@ -1,5 +1,5 @@ <!-- HSTS tab --> -<div id=hstsTabContent> +<div id=hsts-view-tab-content> <p> HSTS is HTTPS Strict Transport Security: a way for sites to elect to always use HTTPS. See <a href="http://dev.chromium.org/sts"> @@ -11,11 +11,11 @@ <h4>Add domain</h4> <p>Input a domain name to add it to the HSTS set:</p> - <form id=hstsAddForm> - Domain: <input type=text id=hstsAddInput type="url" + <form id=hsts-view-add-form> + Domain: <input type=text id=hsts-view-add-input type="url" placeholder="example.com"/><br/> - Include subdomains: <input type="checkbox" id=hstsCheckInput /><br/> - Public key fingerprints: <input type=text id=hstsAddPins style="width: 25em;"/><br/> + Include subdomains: <input type="checkbox" id=hsts-view-check-input /><br/> + Public key fingerprints: <input type=text id=hsts-view-add-pins style="width: 25em;"/><br/> <p style="font-size: small; color: gray; font-style: italic; margin-left: 2em; max-width: 40em;">(public key fingerprints are comma separated and consist of the hash function followed by a foreslash and the base64 encoded fingerprint, for example <tt>sha1/Guzek9lMwR3KeIS8wwS9gBvVtIg=</tt>)</p> <input type=submit value="Add" /> </form> @@ -26,8 +26,8 @@ Input a domain name to delete it from the HSTS set (<i>you cannot delete preloaded entries</i>): </p> - <form id=hstsDeleteForm> - Domain: <input type=text id=hstsDeleteInput type="url" + <form id=hsts-view-delete-form> + Domain: <input type=text id=hsts-view-delete-input type="url" placeholder="example.com"/> <input type=submit value="Delete" /> </form> @@ -35,10 +35,10 @@ <h4>Query domain</h4> <p>Input a domain name to query the current HSTS set:</p> - <form id=hstsQueryForm> - Domain: <input type=text id=hstsQueryInput type="url" + <form id=hsts-view-query-form> + Domain: <input type=text id=hsts-view-query-input type="url" placeholder="example.com"/> <input type=submit value="Query" /> </form> - <div style="margin-top: 1em; margin-left: 2em;" id=hstsQueryOutput></div> + <div style="margin-top: 1em; margin-left: 2em;" id=hsts-view-query-output></div> </div> diff --git a/chrome/browser/resources/net_internals/hsts_view.js b/chrome/browser/resources/net_internals/hsts_view.js index a3acd5d..be335a5 100644 --- a/chrome/browser/resources/net_internals/hsts_view.js +++ b/chrome/browser/resources/net_internals/hsts_view.js @@ -11,16 +11,16 @@ * @constructor */ function HSTSView() { - const mainBoxId = 'hstsTabContent'; - const queryInputId = 'hstsQueryInput'; - const formId = 'hstsQueryForm'; - const queryOutputDivId = 'hstsQueryOutput'; - const addInputId = 'hstsAddInput'; - const addFormId = 'hstsAddForm'; - const addCheckId = 'hstsCheckInput'; - const addPinsId = 'hstsAddPins'; - const deleteInputId = 'hstsDeleteInput'; - const deleteFormId = 'hstsDeleteForm'; + const mainBoxId = 'hsts-view-tab-content'; + const queryInputId = 'hsts-view-query-input'; + const formId = 'hsts-view-query-form'; + const queryOutputDivId = 'hsts-view-query-output'; + const addInputId = 'hsts-view-add-input'; + const addFormId = 'hsts-view-add-form'; + const addCheckId = 'hsts-view-check-input'; + const addPinsId = 'hsts-view-add-pins'; + const deleteInputId = 'hsts-view-delete-input'; + const deleteFormId = 'hsts-view-delete-form'; DivView.call(this, mainBoxId); diff --git a/chrome/browser/resources/net_internals/http_cache_view.html b/chrome/browser/resources/net_internals/http_cache_view.html index 839657dc..235a67a 100644 --- a/chrome/browser/resources/net_internals/http_cache_view.html +++ b/chrome/browser/resources/net_internals/http_cache_view.html @@ -1,9 +1,9 @@ -<div id=httpCacheTabContent> +<div id=http-cache-view-tab-content> <div class="hideOnLoadLog"> <h4>Entries</h4> <a href="chrome://view-http-cache" target=_blank>Explore cache entries</a> </div> <h4>Statistics</h4> - <div id=httpCacheStats>Nothing loaded yet.</div> + <div id=http-cache-view-cache-stats>Nothing loaded yet.</div> </div> diff --git a/chrome/browser/resources/net_internals/http_cache_view.js b/chrome/browser/resources/net_internals/http_cache_view.js index 4090475..1fb20f1 100644 --- a/chrome/browser/resources/net_internals/http_cache_view.js +++ b/chrome/browser/resources/net_internals/http_cache_view.js @@ -7,8 +7,8 @@ * @constructor */ function HttpCacheView() { - const mainBoxId = 'httpCacheTabContent'; - const statsDivId = 'httpCacheStats'; + const mainBoxId = 'http-cache-view-tab-content'; + const statsDivId = 'http-cache-view-cache-stats'; DivView.call(this, mainBoxId); diff --git a/chrome/browser/resources/net_internals/main.css b/chrome/browser/resources/net_internals/main.css index 207bc8d..d384c7e 100644 --- a/chrome/browser/resources/net_internals/main.css +++ b/chrome/browser/resources/net_internals/main.css @@ -43,19 +43,19 @@ body { } /* TODO(eroman): make this a classname instead */ -#detailsLogBox, -#detailsTimelineBox, -#httpCacheTabContent, -#proxyTabContent, +#events-view-details-log-box, +#events-view-details-timeline-box, +#http-cache-view-tab-content, +#proxy-view-tab-content, #capture-view-tab-content, #import-view-tab-content, #export-view-tab-content, -#dnsTabContent, +#dns-view-tab-content, #socketsTabContent, #spdyTabContent, #serviceProvidersTabContent, #testTabContent, -#hstsTabContent, +#hsts-view-tab-content, #httpThrottlingTabContent, #prerenderTabContent, #logs-view-tab-content { @@ -63,11 +63,6 @@ body { padding: 10px; } -#proxyTabContent td, -#proxyTabContent th { - font-size: 12px; -} - /* * Styles for TABLE that uses a thin collapsed border. */ diff --git a/chrome/browser/resources/net_internals/proxy_view.html b/chrome/browser/resources/net_internals/proxy_view.html index 6400d6e..1e07b45 100644 --- a/chrome/browser/resources/net_internals/proxy_view.html +++ b/chrome/browser/resources/net_internals/proxy_view.html @@ -1,15 +1,25 @@ <!-- Proxy info --> -<div id=proxyTabContent> + +<style> + +#proxy-view-tab-content td, +#proxy-view-tab-content th { + font-size: 12px; +} + +</style> + +<div id=proxy-view-tab-content> <h4> Current proxy settings - <input type=button value="Re-apply settings" id=proxyReloadSettings class="hideOnLoadLog"/> + <input type=button value="Re-apply settings" id=proxy-view-reload-settings class="hideOnLoadLog"/> </h4> <table><tr> <td valign=top> <h3>Effective settings</h3> - <pre id=proxyEffectiveSettings></pre> + <pre id=proxy-view-effective-settings></pre> </pre> </td> @@ -17,7 +27,7 @@ <td valign=top> <h3>Original settings</h3> - <pre id=proxyOriginalSettings></pre> + <pre id=proxy-view-original-settings></pre> </td> </tr></table> @@ -29,13 +39,13 @@ </li> <li> Latest proxy resolver event: - <pre id=proxyResolverLog></pre> + <pre id=proxy-view-resolver-log></pre> </li> </ul> <h4> Proxies which have failed recently, and are marked as bad - <input type=button value="Clear bad proxies" id=clearBadProxies class="hideOnLoadLog" /> + <input type=button value="Clear bad proxies" id=proxy-view-clear-bad-proxies class="hideOnLoadLog" /> </h4> <table class="styledTable"> <thead> @@ -44,6 +54,6 @@ <th>Time for next retry</th> </tr> </thead> - <tbody id=badProxiesTableBody></tbody> + <tbody id=proxy-view-bad-proxies-tbody></tbody> </table> </div> diff --git a/chrome/browser/resources/net_internals/proxy_view.js b/chrome/browser/resources/net_internals/proxy_view.js index bece0c4..0d5bd1a 100644 --- a/chrome/browser/resources/net_internals/proxy_view.js +++ b/chrome/browser/resources/net_internals/proxy_view.js @@ -14,13 +14,13 @@ * @constructor */ function ProxyView() { - const mainBoxId = 'proxyTabContent'; - const originalSettingsDivId = 'proxyOriginalSettings'; - const effectiveSettingsDivId = 'proxyEffectiveSettings'; - const reloadSettingsButtonId = 'proxyReloadSettings'; - const badProxiesTbodyId = 'badProxiesTableBody'; - const clearBadProxiesButtonId = 'clearBadProxies'; - const proxyResolverLogPreId = 'proxyResolverLog'; + const mainBoxId = 'proxy-view-tab-content'; + const originalSettingsDivId = 'proxy-view-original-settings'; + const effectiveSettingsDivId = 'proxy-view-effective-settings'; + const reloadSettingsButtonId = 'proxy-view-reload-settings'; + const badProxiesTbodyId = 'proxy-view-bad-proxies-tbody'; + const clearBadProxiesButtonId = 'proxy-view-clear-bad-proxies'; + const proxyResolverLogPreId = 'proxy-view-resolver-log'; DivView.call(this, mainBoxId); |