summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-12-10 19:27:44 +0000
committersergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-12-10 19:27:44 +0000
commitc64315f83800cc4eaaeb4e528cecfaad257f3da3 (patch)
tree04cdcb943a0ce4e9c44af53f2c6e724f0165889e
parentf04182f3be6fb3475134eb562e27fd35ad2442ce (diff)
downloadchromium_src-c64315f83800cc4eaaeb4e528cecfaad257f3da3.zip
chromium_src-c64315f83800cc4eaaeb4e528cecfaad257f3da3.tar.gz
chromium_src-c64315f83800cc4eaaeb4e528cecfaad257f3da3.tar.bz2
Fix leaks in RtpVideoReaderTest.
BUG=65988 TEST=unittests under heapcheck Review URL: http://codereview.chromium.org/5777001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68878 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--remoting/protocol/rtp_video_reader_unittest.cc4
-rw-r--r--tools/heapcheck/suppressions.txt10
-rw-r--r--tools/valgrind/memcheck/suppressions.txt10
3 files changed, 4 insertions, 20 deletions
diff --git a/remoting/protocol/rtp_video_reader_unittest.cc b/remoting/protocol/rtp_video_reader_unittest.cc
index 9af3914..f88ef76 100644
--- a/remoting/protocol/rtp_video_reader_unittest.cc
+++ b/remoting/protocol/rtp_video_reader_unittest.cc
@@ -58,6 +58,10 @@ class RtpVideoReaderTest : public testing::Test,
InitData(100);
}
+ virtual void TearDown() {
+ message_loop_.RunAllPending();
+ }
+
void Reset() {
session_ = new FakeSession();
reader_.reset(new RtpVideoReader());
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt
index 3892a7a..19f0e5d 100644
--- a/tools/heapcheck/suppressions.txt
+++ b/tools/heapcheck/suppressions.txt
@@ -1100,16 +1100,6 @@
fun:remoting::ScreenRecorderTest_OneRecordCycle_Test::TestBody
}
{
- bug_65988
- Heapcheck:Leak
- ...
- fun:remoting::protocol::RtcpWriter::SendReport
- fun:remoting::protocol::RtpVideoReader::SendReceiverReportIf
- fun:remoting::protocol::RtpVideoReader::RebuildVideoPacket
- fun:remoting::protocol::RtpVideoReader::CheckFullPacket
- fun:remoting::protocol::RtpVideoReader::OnRtpPacket
-}
-{
bug_66054_a
Heapcheck:Leak
...
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt
index 9b21ae7..8511de1 100644
--- a/tools/valgrind/memcheck/suppressions.txt
+++ b/tools/valgrind/memcheck/suppressions.txt
@@ -3461,16 +3461,6 @@
fun:_ZN7WebCore11RenderBlock37computeBlockDirectionPositionsForLineEPNS_13RootInlineBoxEPNS_7BidiRunERN3WTF7HashMapIPKNS_13InlineTextBoxESt4pairINS5_6VectorIPKNS_14SimpleFontDataELj0EEENS_13GlyphOverflowEENS5_7PtrHashIS9_EENS5_10HashTraitsIS9_EENSK_ISH_EEEERNS_21VerticalPositionCacheE
}
{
- bug_65988
- Memcheck:Leak
- fun:_Znw*
- fun:_ZN8remoting8protocol24BufferedSocketWriterBase5WriteE13scoped_refptrIN3net16IOBufferWithSizeEEP4Task
- fun:_ZN8remoting8protocol10RtcpWriter10SendReportERKNS0_18RtcpReceiverReportE
- fun:_ZN8remoting8protocol14RtpVideoReader20SendReceiverReportIfEv
- fun:_ZN8remoting8protocol14RtpVideoReader18RebuildVideoPacketESt15_Deque_iteratorINS1_17PacketsQueueEntryERS3_PS3_ES6_
- fun:_ZN8remoting8protocol14RtpVideoReader15CheckFullPacketESt15_Deque_iteratorINS1_17PacketsQueueEntryERS3_PS3_E
-}
-{
bug_66277
Memcheck:Leak
...