summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkn.darshini <kn.darshini@samsung.com>2014-09-18 20:27:33 -0700
committerCommit bot <commit-bot@chromium.org>2014-09-19 03:28:08 +0000
commitcd15c85b2fcea1408f526dcea518f4aeb5500416 (patch)
treef5a3abce32b58e46fd3e5610977c1ec548bdfac4
parent7abfb9121496a420f26d27821924d5ea537d9784 (diff)
downloadchromium_src-cd15c85b2fcea1408f526dcea518f4aeb5500416.zip
chromium_src-cd15c85b2fcea1408f526dcea518f4aeb5500416.tar.gz
chromium_src-cd15c85b2fcea1408f526dcea518f4aeb5500416.tar.bz2
Removing onBookmarkChanged notification to application on history change
and added proper history change notification on history data change. BUG=None Review URL: https://codereview.chromium.org/579753002 Cr-Commit-Position: refs/heads/master@{#295651}
-rw-r--r--AUTHORS1
-rw-r--r--chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java5
-rw-r--r--chrome/browser/android/provider/chrome_browser_provider.cc2
3 files changed, 7 insertions, 1 deletions
diff --git a/AUTHORS b/AUTHORS
index d5fdf27..5ebe252 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -99,6 +99,7 @@ Daniel Johnson <danielj41@gmail.com>
Daniel Nishi <dhnishi@gmail.com>
Daniel Shaulov <dshaulov@ptc.com>
Daniel Trebbien <dtrebbien@gmail.com>
+Darshini KN <kn.darshini@samsung.com>
David Benjamin <davidben@mit.edu>
David Erceg <erceg.david@gmail.com>
David Futcher <david.mike.futcher@gmail.com>
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
index 8a17069..add6afe 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
@@ -1045,6 +1045,11 @@ public class ChromeBrowserProvider extends ContentProvider {
}
@CalledByNative
+ private void onHistoryChanged() {
+ notifyChange(buildAPIContentUri(getContext(), HISTORY_PATH));
+ }
+
+ @CalledByNative
private void onSearchTermChanged() {
notifyChange(buildAPIContentUri(getContext(), SEARCHES_PATH));
}
diff --git a/chrome/browser/android/provider/chrome_browser_provider.cc b/chrome/browser/android/provider/chrome_browser_provider.cc
index d47bc4c..b0d4ad0 100644
--- a/chrome/browser/android/provider/chrome_browser_provider.cc
+++ b/chrome/browser/android/provider/chrome_browser_provider.cc
@@ -1613,7 +1613,7 @@ void ChromeBrowserProvider::Observe(
ScopedJavaLocalRef<jobject> obj = weak_java_provider_.get(env);
if (obj.is_null())
return;
- Java_ChromeBrowserProvider_onBookmarkChanged(env, obj.obj());
+ Java_ChromeBrowserProvider_onHistoryChanged(env, obj.obj());
} else if (type ==
chrome::NOTIFICATION_HISTORY_KEYWORD_SEARCH_TERM_UPDATED) {
JNIEnv* env = AttachCurrentThread();