diff options
| author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-30 20:50:54 +0000 |
|---|---|---|
| committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-30 20:50:54 +0000 |
| commit | e27a5f5229ae9c5257569c1c8d0f632c115a5cd7 (patch) | |
| tree | 81ecb87faa0ce9f97246104c64cb76c4a034279a | |
| parent | 8f777e5af27a681c263c39bbc7b348cf5187c4d4 (diff) | |
| download | chromium_src-e27a5f5229ae9c5257569c1c8d0f632c115a5cd7.zip chromium_src-e27a5f5229ae9c5257569c1c8d0f632c115a5cd7.tar.gz chromium_src-e27a5f5229ae9c5257569c1c8d0f632c115a5cd7.tar.bz2 | |
Add a list of excluded files to checkbins.py and enable it on build bots.
After some research it turns out we can exclude certain .exe/.dll files from /NXCOMPAT and /DYNAMICBASE due to various reasons (pure data DLLs, special purpose applications, non-shipping code, etc...)
BUG=25952
TEST=checkbins step on buildbot should stay green with no failing files
Review URL: http://codereview.chromium.org/1576003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43135 0039d316-1c4b-4281-b951-d872f2087c98
| -rwxr-xr-x | tools/checkbins/checkbins.py | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/tools/checkbins/checkbins.py b/tools/checkbins/checkbins.py index 05fc81f..362e43e 100755 --- a/tools/checkbins/checkbins.py +++ b/tools/checkbins/checkbins.py @@ -1,5 +1,5 @@ #!/usr/bin/python -# Copyright (c) 2009 The Chromium Authors. All rights reserved. +# Copyright (c) 2010 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -23,9 +23,18 @@ PE_FILE_EXTENSIONS = ['.exe', '.dll'] DYNAMICBASE_FLAG = 0x0040 NXCOMPAT_FLAG = 0x0100 +# Please do not add your file here without confirming that it indeed doesn't +# require /NXCOMPAT and /DYNAMICBASE. Contact cpu@chromium.org or your local +# Windows guru for advice. +EXCLUDED_FILES = ['chrome_frame_mini_installer.exe', + 'icudt42.dll', + 'mini_installer.exe', + 'wow_helper.exe'] + def IsPEFile(path): return (os.path.isfile(path) and - os.path.splitext(path)[1].lower() in PE_FILE_EXTENSIONS) + os.path.splitext(path)[1].lower() in PE_FILE_EXTENSIONS and + os.path.basename(path) not in EXCLUDED_FILES) def main(options, args): directory = args[0] @@ -62,8 +71,7 @@ def main(options, args): print "Result: %d files found, %d files passed" % (pe_total, pe_passed) if pe_passed != pe_total: - # TODO(scherkus): change this back to 1 once I've fixed failing builds. - sys.exit(0) + sys.exit(1) if __name__ == '__main__': usage = "Usage: %prog [options] DIRECTORY" |