summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsatish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-28 11:28:40 +0000
committersatish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-28 11:28:40 +0000
commitff3f6df11a7fcef3c002f063128658dc5fdee6c1 (patch)
tree9a563aef729ad147336a84fba83f73b6cc27bd8e
parent329cb6e677c375773eb71f0a63f0b2b25149765d (diff)
downloadchromium_src-ff3f6df11a7fcef3c002f063128658dc5fdee6c1.zip
chromium_src-ff3f6df11a7fcef3c002f063128658dc5fdee6c1.tar.gz
chromium_src-ff3f6df11a7fcef3c002f063128658dc5fdee6c1.tar.bz2
Add some log messages to track down a test timing out occasionally.
BUG=54044 TEST=none Review URL: http://codereview.chromium.org/3510002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60772 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/speech/speech_input_bubble_controller_unittest.cc9
1 files changed, 7 insertions, 2 deletions
diff --git a/chrome/browser/speech/speech_input_bubble_controller_unittest.cc b/chrome/browser/speech/speech_input_bubble_controller_unittest.cc
index bc479c8..8bd4fab5 100644
--- a/chrome/browser/speech/speech_input_bubble_controller_unittest.cc
+++ b/chrome/browser/speech/speech_input_bubble_controller_unittest.cc
@@ -23,11 +23,13 @@ class MockSpeechInputBubble : public SpeechInputBubbleBase {
};
MockSpeechInputBubble(TabContents*, Delegate* delegate, const gfx::Rect&) {
+ LOG(INFO) << "MockSpeechInputBubble created";
MessageLoop::current()->PostTask(
FROM_HERE, NewRunnableFunction(&InvokeDelegate, delegate));
}
static void InvokeDelegate(Delegate* delegate) {
+ LOG(INFO) << "MockSpeechInputBubble invoking delegate for type " << type_;
switch (type_) {
case BUBBLE_TEST_FOCUS_CHANGED:
delegate->InfoBubbleFocusChanged();
@@ -82,6 +84,7 @@ class SpeechInputBubbleControllerTest
// SpeechInputBubbleControllerDelegate methods.
virtual void InfoBubbleButtonClicked(int caller_id,
SpeechInputBubble::Button button) {
+ LOG(INFO) << "Received InfoBubbleButtonClicked for button " << button;
EXPECT_TRUE(ChromeThread::CurrentlyOn(ChromeThread::IO));
if (button == SpeechInputBubble::BUTTON_CANCEL) {
cancel_clicked_ = true;
@@ -92,6 +95,7 @@ class SpeechInputBubbleControllerTest
}
virtual void InfoBubbleFocusChanged(int caller_id) {
+ LOG(INFO) << "Received InfoBubbleFocusChanged";
EXPECT_TRUE(ChromeThread::CurrentlyOn(ChromeThread::IO));
focus_changed_ = true;
MessageLoop::current()->Quit();
@@ -157,9 +161,10 @@ MockSpeechInputBubble::BubbleType MockSpeechInputBubble::type_ =
// Test that the speech bubble UI gets created in the UI thread and that the
// focus changed callback comes back in the IO thread.
//
-// Crashes on Win only. http://crbug.com/54044
+// This test times out sometimes on windows, see http://crbug.com/54044. To
+// help find the cause it is left running so we can collect logs when it fails.
#if defined(OS_WIN)
-#define MAYBE_TestFocusChanged DISABLED_TestFocusChanged
+#define MAYBE_TestFocusChanged FLAKY_TestFocusChanged
#else
#define MAYBE_TestFocusChanged TestFocusChanged
#endif