summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWalter Korman <wkorman@google.com>2016-03-01 17:19:33 -0800
committerWalter Korman <wkorman@google.com>2016-03-02 01:21:44 +0000
commitcf4a0d2cb1c47c04b274c2f8b68450d90a8f1326 (patch)
tree0a8bd86f846ba4f78d3eaf67d3805eefd3fae8f2
parentdd17c09c5dcdedd932127a5b0226044658bee70c (diff)
downloadchromium_src-cf4a0d2cb1c47c04b274c2f8b68450d90a8f1326.zip
chromium_src-cf4a0d2cb1c47c04b274c2f8b68450d90a8f1326.tar.gz
chromium_src-cf4a0d2cb1c47c04b274c2f8b68450d90a8f1326.tar.bz2
Don't anti-alias clips in the Blink-replay path.
This is a workaround to unblock M49. BUG=590971 R=fmalita@chromium.org TBR=chrishtr Review URL: https://codereview.chromium.org/1751993004 . Cr-Commit-Position: refs/heads/master@{#378635} (cherry picked from commit 8679e8bbd2de5b40e7f9b1c9cfc7585446caa0e6) Review URL: https://codereview.chromium.org/1753083002 . Cr-Commit-Position: refs/branch-heads/2623@{#560} Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
-rw-r--r--third_party/WebKit/LayoutTests/TestExpectations27
-rw-r--r--third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp4
2 files changed, 7 insertions, 24 deletions
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations
index 2a9780a..02b2188 100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1218,27 +1218,9 @@ crbug.com/521730 [ Win10 ] svg/as-image/svg-canvas-xhtml-tainted.html [ Failure
crbug.com/521730 [ Win10 ] svg/css/text-shadow-multiple.xhtml [ Failure ]
crbug.com/521730 [ Win10 ] svg/custom/textPath-change-id2-pattern.svg [ Failure ]
-crbug.com/390040 css3/filters/nested-filter.html [ NeedsRebaseline ]
-crbug.com/390040 fast/borders/border-radius-percent.html [ NeedsRebaseline ]
-crbug.com/390040 fast/css/resize-corner-tracking-transformed.html [ NeedsRebaseline ]
-crbug.com/390040 fast/forms/select-popup/popup-menu-appearance-transform.html [ NeedsRebaseline ]
-crbug.com/390040 fast/frames/frame-set-scaling-rotate.html [ NeedsRebaseline ]
-crbug.com/390040 fast/frames/frame-set-scaling-skew.html [ NeedsRebaseline ]
-crbug.com/390040 fast/overflow/overflow-update-transform.html [ NeedsRebaseline ]
-crbug.com/390040 fast/replaced/selection-rect-transform.html [ NeedsRebaseline ]
-crbug.com/390040 fast/transforms/transformed-focused-text-input.html [ NeedsRebaseline ]
-crbug.com/390040 inspector/layers/layer-canvas-log.html [ NeedsRebaseline ]
-crbug.com/390040 media/audio-repaint.html [ NeedsRebaseline ]
-crbug.com/390040 printing/iframe-print.html [ NeedsRebaseline ]
-crbug.com/390040 svg/dynamic-updates/SVG-dynamic-css-transform.html [ NeedsRebaseline ]
-crbug.com/390040 virtual/threaded/printing/iframe-print.html [ NeedsRebaseline ]
-crbug.com/390040 fast/forms/placeholder-position.html [ NeedsRebaseline ]
-crbug.com/390040 svg/transforms/animated-path-inside-transformed-html.xhtml [ NeedsRebaseline ]
-crbug.com/390040 svg/transforms/text-with-pattern-inside-transformed-html.xhtml [ NeedsRebaseline ]
-crbug.com/390040 virtual/threaded/printing/ellipsis-printing-style.html [ NeedsRebaseline ]
-crbug.com/390040 printing/ellipsis-printing-style.html [ NeedsRebaseline ]
-crbug.com/390040 fast/forms/select/listbox-appearance-basic.html [ NeedsRebaseline ]
-crbug.com/390040 fast/frames/iframe-scaling-with-scroll.html [ NeedsRebaseline ]
+# TODO(chrishtr): re-enable these after crbug.com/590971 is fixed.
+# crbug.com/390040 [ Win10 ] virtual/threaded/printing/ellipsis-printing-style.html [ Skip ]
+# crbug.com/390040 [ Win10 ] printing/ellipsis-printing-style.html [ Skip ]
crbug.com/571233 compositing/background-color/background-color-outside-document.html [ Skip ]
@@ -1436,7 +1418,6 @@ crbug.com/569950 svg/batik/filters/feTile.svg [ NeedsRebaseline ]
crbug.com/569950 svg/filters/feTile.svg [ NeedsRebaseline ]
crbug.com/570611 fast/inline/inline-box-background-repeat-x.html [ NeedsRebaseline ]
-crbug.com/570611 [ Mac Linux Android XP Win7 ] fast/text/emphasis-combined-text.html [ NeedsRebaseline ]
crbug.com/570611 ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box.htm [ NeedsRebaseline ]
crbug.com/568867 [ Win Debug ] transforms/3d/point-mapping/3d-point-mapping-deep.html [ Failure ]
@@ -1487,4 +1468,4 @@ crbug.com/577381 [ Linux Debug ] imported/web-platform-tests/html/syntax/parsing
crbug.com/577381 [ Linux Debug ] imported/web-platform-tests/html/syntax/parsing/html5lib_tests10.html [ Slow ]
crbug.com/577381 [ Linux Debug ] imported/web-platform-tests/html/syntax/parsing/html5lib_webkit01.html [ Slow ]
-crbug.com/577746 [ Linux Debug ] compositing/iframes/iframe-in-composited-layer.html [ Pass Failure ] \ No newline at end of file
+crbug.com/577746 [ Linux Debug ] compositing/iframes/iframe-in-composited-layer.html [ Pass Failure ]
diff --git a/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp
index a1557a1..e4563be 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp
@@ -14,7 +14,9 @@ namespace blink {
void ClipDisplayItem::replay(GraphicsContext& context) const
{
context.save();
- context.clipRect(m_clipRect, AntiAliased);
+ // TODO(chrishtr): make this AntiAliased. Not anti-aliasing here is a workaround for a PDF rendering issue.
+ // See crbug.com/590971.
+ context.clipRect(m_clipRect, NotAntiAliased);
for (const FloatRoundedRect& roundedRect : m_roundedRectClips)
context.clipRoundedRect(roundedRect);