diff options
| author | dpranke <dpranke@chromium.org> | 2016-02-04 16:13:08 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-05 00:14:14 +0000 |
| commit | aad45df87355a1836a921921e9c8399889c0ee3b (patch) | |
| tree | 000a65ac425d436e84ba87c1c48f4ab33c3166fd | |
| parent | 1384534a94e6324d74906f0cbc1e707606c063f2 (diff) | |
| download | chromium_src-aad45df87355a1836a921921e9c8399889c0ee3b.zip chromium_src-aad45df87355a1836a921921e9c8399889c0ee3b.tar.gz chromium_src-aad45df87355a1836a921921e9c8399889c0ee3b.tar.bz2 | |
Revert of Build "all" instead of "gn_all" on Linux builders. (patchset #1 id:1 of https://codereview.chromium.org/1665613002/ )
Reason for revert:
GN analyze doesn't work w/ 'all' properly, so this change was a bad idea.
technically, it doesn't work all that well w/ additional_compile_targets=['gn_all'] either.
See crbug.com/555273.
Original issue's description:
> Build "all" instead of "gn_all" on Linux builders.
>
> R=jam@chromium.org, phajdan.jr@chromium.org
>
> Committed: https://crrev.com/5649c2fe6ff65b80064ded810fe922c86a093a66
> Cr-Commit-Position: refs/heads/master@{#373299}
TBR=phajdan.jr@chromium.org,jam@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/1668253003
Cr-Commit-Position: refs/heads/master@{#373674}
| -rw-r--r-- | testing/buildbot/chromium.json | 2 | ||||
| -rw-r--r-- | testing/buildbot/chromium.linux.json | 8 |
2 files changed, 7 insertions, 3 deletions
diff --git a/testing/buildbot/chromium.json b/testing/buildbot/chromium.json index f47bedd..9cfd9e5 100644 --- a/testing/buildbot/chromium.json +++ b/testing/buildbot/chromium.json @@ -23,7 +23,7 @@ }, "Linux x64": { "additional_compile_targets": [ - "all" + "gn_all" ], "scripts": [ { diff --git a/testing/buildbot/chromium.linux.json b/testing/buildbot/chromium.linux.json index 5e2cec07..378248c 100644 --- a/testing/buildbot/chromium.linux.json +++ b/testing/buildbot/chromium.linux.json @@ -529,12 +529,16 @@ }, "Linux Builder": { "additional_compile_targets": [ - "all" + "battor_agent", + "blimp", + "mandoline:all", + "mash:all", + "remoting_all" ] }, "Linux Builder (dbg)": { "additional_compile_targets": [ - "all" + "gn_all" ] }, "Linux Tests": { |