diff options
author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-21 21:43:25 +0000 |
---|---|---|
committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-21 21:43:25 +0000 |
commit | 5e0aa828d3a30dd7ab913ded968cc846ef664bb6 (patch) | |
tree | 5d6218b4ffe93b05fa0e9fa323759bcd1a633a10 | |
parent | e1be2a0928db5f6feeb4f7a9fe1d563e9e9fff45 (diff) | |
download | chromium_src-5e0aa828d3a30dd7ab913ded968cc846ef664bb6.zip chromium_src-5e0aa828d3a30dd7ab913ded968cc846ef664bb6.tar.gz chromium_src-5e0aa828d3a30dd7ab913ded968cc846ef664bb6.tar.bz2 |
Merge r53244 from the trunk to the 472 branch:
Update Breakpad from r627 to r628 to pick up:
Separate the "hello" message from the parameter messages in
Inspector::ReadMessages as was done before r627. The "hello" message contains
the parameter count and is referenced while the message reader loops through
parameter messages. Prior to r627, both messages were named |message|, which
was confusing, probably caused a compiler warning, and apparently provided the
motivation to share them. This caused the crash inspector to fail to properly
collect the parameters. The common failure mode (although others are possible)
was for the inspector to attempt tor read more parameter messages than were
available, resulting in an IPC timeout and inspector death. No crash report
would be written, and the application expecting its crash to be inspected
would time out waiting for a response from the inspector and then _exit. Thisis effectively a failure to properly handle crashes.
The inner message is reintroduced, and named parameter_message for
disambiguation.
BUG=49821
TEST= - Crashes catchable by the Mac Breakpad framework.
- about:crash and its browser equivalent works and produces crash dumps
in ~/Library/Breakpad/Chrome_Mac
Review URL: http://codereview.chromium.org/2861072
git-svn-id: svn://svn.chromium.org/chrome/branches/472/src@53249 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | DEPS | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -13,7 +13,7 @@ vars = { deps = { "src/breakpad/src": - "http://google-breakpad.googlecode.com/svn/trunk/src@627", + "http://google-breakpad.googlecode.com/svn/trunk/src@628", "src/build/util/support": "/trunk/deps/support@20411", |