summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpamg@google.com <pamg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-21 16:58:36 +0000
committerpamg@google.com <pamg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-21 16:58:36 +0000
commit1f3c7dd66d07bc26ea2558b4864b1d05a2dd75ae (patch)
tree38a5621559d55aa7ac3f86e14c2bb4fa7178cc4a
parent6ab03fc09aa1a2ea4e8cec6879e6602ad5f4826d (diff)
downloadchromium_src-1f3c7dd66d07bc26ea2558b4864b1d05a2dd75ae.zip
chromium_src-1f3c7dd66d07bc26ea2558b4864b1d05a2dd75ae.tar.gz
chromium_src-1f3c7dd66d07bc26ea2558b4864b1d05a2dd75ae.tar.bz2
Split startup-test graphs into cold and warm, since otherwise the plot axis
is too large for changes in warm timings to show up well. BUG=3597 TEST=warm-test results show up better on startup-test plot Review URL: http://codereview.chromium.org/7531 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3657 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/test/startup/startup_test.cc18
1 files changed, 11 insertions, 7 deletions
diff --git a/chrome/test/startup/startup_test.cc b/chrome/test/startup/startup_test.cc
index 10d0bff..583dd58 100644
--- a/chrome/test/startup/startup_test.cc
+++ b/chrome/test/startup/startup_test.cc
@@ -33,7 +33,8 @@ class StartupTest : public UITest {
void SetUp() {}
void TearDown() {}
- void RunStartupTest(const wchar_t* label, bool test_cold, bool important) {
+ void RunStartupTest(const wchar_t* graph, const wchar_t* trace,
+ bool test_cold, bool important) {
const int kNumCycles = 20;
// Make a backup of gears.dll so we can overwrite the original, which
@@ -77,7 +78,7 @@ class StartupTest : public UITest {
std::wstring times;
for (int i = 0; i < kNumCycles; ++i)
StringAppendF(&times, L"%.2f,", timings[i].InMillisecondsF());
- PrintResultList(L"startup", L"", label, times, L"ms", important);
+ PrintResultList(graph, L"", trace, times, L"ms", important);
}
protected:
@@ -114,24 +115,27 @@ class StartupFileTest : public StartupTest {
} // namespace
TEST_F(StartupTest, Perf) {
- RunStartupTest(L"warm", false /* not cold */, true /* important */);
+ RunStartupTest(L"warm", L"t", false /* not cold */, true /* important */);
}
TEST_F(StartupReferenceTest, Perf) {
- RunStartupTest(L"warm_ref", false /* not cold */, true /* important */);
+ RunStartupTest(L"warm", L"t_ref", false /* not cold */,
+ true /* important */);
}
// TODO(mpcomplete): Should we have reference timings for all these?
TEST_F(StartupTest, PerfCold) {
- RunStartupTest(L"cold", true /* cold */, false /* not important */);
+ RunStartupTest(L"cold", L"t", true /* cold */, false /* not important */);
}
TEST_F(StartupFileTest, PerfGears) {
- RunStartupTest(L"gears", false /* not cold */, false /* not important */);
+ RunStartupTest(L"warm", L"gears", false /* not cold */,
+ false /* not important */);
}
TEST_F(StartupFileTest, PerfColdGears) {
- RunStartupTest(L"gears_cold", true /* cold */, false /* not important */);
+ RunStartupTest(L"cold", L"gears", true /* cold */,
+ false /* not important */);
}