diff options
| author | Niklas Enbom <niklase@chromium.org> | 2016-03-11 13:35:14 -0800 |
|---|---|---|
| committer | Niklas Enbom <niklase@chromium.org> | 2016-03-11 21:37:00 +0000 |
| commit | 6f4fa599e1ab21a4784c11c599d6fa5b52e8bc60 (patch) | |
| tree | 5fd53f343f4da3ebea359ddf37b4a0ac4f369423 | |
| parent | 4a5c529d37e17c3ea7def8aa7de2507a5548d84d (diff) | |
| download | chromium_src-6f4fa599e1ab21a4784c11c599d6fa5b52e8bc60.zip chromium_src-6f4fa599e1ab21a4784c11c599d6fa5b52e8bc60.tar.gz chromium_src-6f4fa599e1ab21a4784c11c599d6fa5b52e8bc60.tar.bz2 | |
Remove the UseDelayAgnosticAEC experiment code
The experiment has been 100% enabled for several months now. With this
change, the delay agnostic AEC is always enabled (for desktops) unless
switches::kDisableDelayAgnosticAec disables it.
BUG=450193
Review URL: https://codereview.chromium.org/1603693004
Cr-Commit-Position: refs/heads/master@{#370370}
(cherry picked from commit 2622d7364c69af1f6cc53e5f53a0d8f7eb116aaf)
Review URL: https://codereview.chromium.org/1792513002 .
Cr-Commit-Position: refs/branch-heads/2623@{#614}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
5 files changed, 1 insertions, 28 deletions
diff --git a/content/renderer/media/media_stream_audio_processor.cc b/content/renderer/media/media_stream_audio_processor.cc index 1deb1e4..79988e2 100644 --- a/content/renderer/media/media_stream_audio_processor.cc +++ b/content/renderer/media/media_stream_audio_processor.cc @@ -102,15 +102,8 @@ void RecordProcessingState(AudioTrackProcessingStates state) { } bool IsDelayAgnosticAecEnabled() { - // Note: It's important to query the field trial state first, to ensure that - // UMA reports the correct group. - const std::string group_name = - base::FieldTrialList::FindFullName("UseDelayAgnosticAEC"); base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); - if (command_line->HasSwitch(switches::kDisableDelayAgnosticAec)) - return false; - - return (group_name == "Enabled" || group_name == "DefaultEnabled"); + return !command_line->HasSwitch(switches::kDisableDelayAgnosticAec); } // Checks if the default minimum starting volume value for the AGC is overridden diff --git a/testing/variations/fieldtrial_testing_config_chromeos.json b/testing/variations/fieldtrial_testing_config_chromeos.json index 1e1fd2f..01c539e 100644 --- a/testing/variations/fieldtrial_testing_config_chromeos.json +++ b/testing/variations/fieldtrial_testing_config_chromeos.json @@ -136,11 +136,6 @@ "group_name": "Enabled" } ], - "UseDelayAgnosticAEC": [ - { - "group_name": "DefaultEnabled" - } - ], "VarationsServiceControl": [ { "group_name": "Interval_30min", diff --git a/testing/variations/fieldtrial_testing_config_linux.json b/testing/variations/fieldtrial_testing_config_linux.json index c382153..7a904ac 100644 --- a/testing/variations/fieldtrial_testing_config_linux.json +++ b/testing/variations/fieldtrial_testing_config_linux.json @@ -175,11 +175,6 @@ "group_name": "Enabled" } ], - "UseDelayAgnosticAEC": [ - { - "group_name": "DefaultEnabled" - } - ], "VarationsServiceControl": [ { "group_name": "Interval_30min", diff --git a/testing/variations/fieldtrial_testing_config_mac.json b/testing/variations/fieldtrial_testing_config_mac.json index d0ef9d2..7948154 100644 --- a/testing/variations/fieldtrial_testing_config_mac.json +++ b/testing/variations/fieldtrial_testing_config_mac.json @@ -188,11 +188,6 @@ "group_name": "Enabled" } ], - "UseDelayAgnosticAEC": [ - { - "group_name": "DefaultEnabled" - } - ], "VarationsServiceControl": [ { "group_name": "Interval_30min", diff --git a/testing/variations/fieldtrial_testing_config_win.json b/testing/variations/fieldtrial_testing_config_win.json index f306514..64507f4 100644 --- a/testing/variations/fieldtrial_testing_config_win.json +++ b/testing/variations/fieldtrial_testing_config_win.json @@ -267,11 +267,6 @@ "group_name": "On" } ], - "UseDelayAgnosticAEC": [ - { - "group_name": "DefaultEnabled" - } - ], "VarationsServiceControl": [ { "group_name": "Interval_30min", |