diff options
| author | arv@chromium.org <arv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-11 01:20:32 +0000 |
|---|---|---|
| committer | arv@chromium.org <arv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-11 01:20:32 +0000 |
| commit | 3970fddcbe03a4c9fe5368a54962352391d2af8c (patch) | |
| tree | 13a098bf6f9bb1deca621772572ea0c73b6a395f | |
| parent | a45de6cef2423ba700fda4c5207d9f392ef2a851 (diff) | |
| download | chromium_src-3970fddcbe03a4c9fe5368a54962352391d2af8c.zip chromium_src-3970fddcbe03a4c9fe5368a54962352391d2af8c.tar.gz chromium_src-3970fddcbe03a4c9fe5368a54962352391d2af8c.tar.bz2 | |
Remove usage of deprecated DOM API
Use defaultPrevented instead of returnValue
BUG=None
Review URL: https://codereview.chromium.org/26924002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228073 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/resources/ntp_android/ntp_android.js | 4 | ||||
| -rw-r--r-- | ui/webui/resources/js/util.js | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/chrome/browser/resources/ntp_android/ntp_android.js b/chrome/browser/resources/ntp_android/ntp_android.js index d641eec..ad62da0 100644 --- a/chrome/browser/resources/ntp_android/ntp_android.js +++ b/chrome/browser/resources/ntp_android/ntp_android.js @@ -1183,9 +1183,7 @@ cr.define('ntp', function() { * @param {Object} evt User interface event that triggered the action. */ function executePromoAction(evt) { - if (evt.preventDefault) - evt.preventDefault(); - evt.returnValue = false; + evt.preventDefault(); chrome.send('promoActionTriggered'); } diff --git a/ui/webui/resources/js/util.js b/ui/webui/resources/js/util.js index bec9c3b..c345a4f 100644 --- a/ui/webui/resources/js/util.js +++ b/ui/webui/resources/js/util.js @@ -216,7 +216,7 @@ function getRequiredElement(id) { // call into the browser to do the navigation. document.addEventListener('click', function(e) { // Allow preventDefault to work. - if (!e.returnValue) + if (!e.defaultPrevented) return; var el = e.target; |