summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorscr@chromium.org <scr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-12 23:33:36 +0000
committerscr@chromium.org <scr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-12 23:33:36 +0000
commit4e0cb1b6985dc73dc7097266b937fd03d8a12026 (patch)
treef4c489c5c26f747510e2b8685cbe0d93f61d72f1
parentdb8ff912c0325d5bbff4b989de637ee371d09406 (diff)
downloadchromium_src-4e0cb1b6985dc73dc7097266b937fd03d8a12026.zip
chromium_src-4e0cb1b6985dc73dc7097266b937fd03d8a12026.tar.gz
chromium_src-4e0cb1b6985dc73dc7097266b937fd03d8a12026.tar.bz2
Coverity PASS_BY_VALUE fix.
CID=104112, 104110, 104109 BUG=None TEST= R=jeremya@chromium.org Review URL: https://chromiumcodereview.appspot.com/10443075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141785 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h2
-rw-r--r--chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm4
-rw-r--r--chrome/browser/ui/extensions/shell_window.cc2
-rw-r--r--chrome/browser/ui/extensions/shell_window.h4
-rw-r--r--chrome/browser/ui/gtk/extensions/shell_window_gtk.cc4
-rw-r--r--chrome/browser/ui/gtk/extensions/shell_window_gtk.h2
-rw-r--r--chrome/browser/ui/views/extensions/shell_window_views.cc2
7 files changed, 10 insertions, 10 deletions
diff --git a/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h b/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h
index fe0a2e8..75fd332 100644
--- a/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h
+++ b/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h
@@ -33,7 +33,7 @@ class ShellWindowCocoa : public ShellWindow {
ShellWindowCocoa(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const CreateParams params);
+ const CreateParams& params);
// BaseWindow implementation.
virtual bool IsActive() const OVERRIDE;
diff --git a/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm b/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
index 0c25687..784331a 100644
--- a/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm
@@ -27,7 +27,7 @@
ShellWindowCocoa::ShellWindowCocoa(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params)
+ const ShellWindow::CreateParams& params)
: ShellWindow(profile, extension, url),
attention_request_id_(0) {
NSRect rect = NSMakeRect(params.bounds.x(), params.bounds.y(),
@@ -177,6 +177,6 @@ NSWindow* ShellWindowCocoa::window() const {
ShellWindow* ShellWindow::CreateImpl(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params) {
+ const ShellWindow::CreateParams& params) {
return new ShellWindowCocoa(profile, extension, url, params);
}
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc
index dea51c2..ca41ef1 100644
--- a/chrome/browser/ui/extensions/shell_window.cc
+++ b/chrome/browser/ui/extensions/shell_window.cc
@@ -47,7 +47,7 @@ ShellWindow::CreateParams::CreateParams()
ShellWindow* ShellWindow::Create(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params) {
+ const ShellWindow::CreateParams& params) {
// This object will delete itself when the window is closed.
ShellWindow* window =
ShellWindow::CreateImpl(profile, extension, url, params);
diff --git a/chrome/browser/ui/extensions/shell_window.h b/chrome/browser/ui/extensions/shell_window.h
index 5b051ed..b7f8f81 100644
--- a/chrome/browser/ui/extensions/shell_window.h
+++ b/chrome/browser/ui/extensions/shell_window.h
@@ -55,7 +55,7 @@ class ShellWindow : public content::NotificationObserver,
static ShellWindow* Create(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const CreateParams params);
+ const CreateParams& params);
const SessionID& session_id() const { return session_id_; }
const extensions::Extension* extension() const { return extension_; }
@@ -89,7 +89,7 @@ class ShellWindow : public content::NotificationObserver,
static ShellWindow* CreateImpl(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- CreateParams params);
+ const CreateParams& params);
// content::WebContentsObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
diff --git a/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc b/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
index b2b85d4..19163af 100644
--- a/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
+++ b/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
@@ -15,7 +15,7 @@
ShellWindowGtk::ShellWindowGtk(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params)
+ const ShellWindow::CreateParams& params)
: ShellWindow(profile, extension, url),
state_(GDK_WINDOW_STATE_WITHDRAWN),
is_active_(!ui::ActiveWindowWatcherX::WMSupportsActivation()) {
@@ -174,6 +174,6 @@ gboolean ShellWindowGtk::OnWindowState(GtkWidget* sender,
ShellWindow* ShellWindow::CreateImpl(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params) {
+ const ShellWindow::CreateParams& params) {
return new ShellWindowGtk(profile, extension, url, params);
}
diff --git a/chrome/browser/ui/gtk/extensions/shell_window_gtk.h b/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
index eaf6793..2f713a0 100644
--- a/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
+++ b/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
@@ -27,7 +27,7 @@ class ShellWindowGtk : public ShellWindow,
ShellWindowGtk(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const CreateParams params);
+ const CreateParams& params);
// BaseWindow implementation.
virtual bool IsActive() const OVERRIDE;
diff --git a/chrome/browser/ui/views/extensions/shell_window_views.cc b/chrome/browser/ui/views/extensions/shell_window_views.cc
index c3e233b..a98a989 100644
--- a/chrome/browser/ui/views/extensions/shell_window_views.cc
+++ b/chrome/browser/ui/views/extensions/shell_window_views.cc
@@ -444,6 +444,6 @@ void ShellWindowViews::UpdateWindowTitle() {
ShellWindow* ShellWindow::CreateImpl(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params) {
+ const ShellWindow::CreateParams& params) {
return new ShellWindowViews(profile, extension, url, params);
}