diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-04 01:18:49 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-04 01:18:49 +0000 |
| commit | ac08ddcae18f34d2d2d1498c12c9f423d5772cda (patch) | |
| tree | 5cd7810b3f25fd27ef605bf8585ce274e5a4af9a /AUTHORS | |
| parent | d8333f2904812f8febbf10988bca118ad6e1a0ed (diff) | |
| download | chromium_src-ac08ddcae18f34d2d2d1498c12c9f423d5772cda.zip chromium_src-ac08ddcae18f34d2d2d1498c12c9f423d5772cda.tar.gz chromium_src-ac08ddcae18f34d2d2d1498c12c9f423d5772cda.tar.bz2 | |
Revert 120018 - Revert 120005 - Enabled pressing TAB to traverse through the Omnibox results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs.
This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.
The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message.
If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.
Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.
This also addresses some GTK omnibox browsertest flakiness; see bug 112041.
Contributed by aaron.randolph@gmail.com
BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.
Review URL: http://codereview.chromium.org/6731036
TBR=aaron.randolph@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9310017
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9309097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120448 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'AUTHORS')
| -rw-r--r-- | AUTHORS | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -160,3 +160,4 @@ François Beaufort <beaufort.francois@gmail.com> Eriq Augustine <eriq.augustine@gmail.com> Francois Kritzinger <francoisk777@gmail.com> Erik Hill <erikghill@gmail.com> +Aaron Randolph <aaron.randolph@gmail.com> |