diff options
| author | gspencer@chromium.org <gspencer@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-04 22:26:48 +0000 |
|---|---|---|
| committer | gspencer@chromium.org <gspencer@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-04 22:26:48 +0000 |
| commit | 88efee42661d41ab0985b4fe1ab7ffe18ac279a1 (patch) | |
| tree | 9e32396c4e0abf80d63014ee9e0d6283c775983d /AUTHORS | |
| parent | 3cd0756d48b8a6c910c1e041ebf1605ef777851c (diff) | |
| download | chromium_src-88efee42661d41ab0985b4fe1ab7ffe18ac279a1.zip chromium_src-88efee42661d41ab0985b4fe1ab7ffe18ac279a1.tar.gz chromium_src-88efee42661d41ab0985b4fe1ab7ffe18ac279a1.tar.bz2 | |
Fix proxy settings so that a port number in the host field gets applied to the port field.
chrome/browser/chromeos/proxy_cros_settings_parser.cc:85 The port
number's final value comes from either the one specified in the Host
field or the one specified in the Port field. Which one it would be
depends on which field is the last updated field, so the
overriding-it-whatever logic will be no longer necessary, and we
removed it.
chrome/browser/resources/options/chromeos/internet_detail.js:524 Add a
new function called "updateProxySetting", it is used to update the
proxy setting dialog's UI. Whenever the internal data storing the
proxy information is changed, this function is called to update the UI
instantly.
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:167
When the proxy data settings changed, make sure the view is updated
properly by calling JS function - updateProxySettings.
This patch was contributed by keenepan@linpus.com, and originally
reviewed in CL
TBR=pastarmovj@chromium.org
BUG=chromium-os:26554
TEST=Setting manual proxy with "http://" prefix AND ":<port>" suffix, the proxy settings dialog UI will update and values will in right TEXTVIEW
Review URL: https://chromiumcodereview.appspot.com/11737038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175213 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'AUTHORS')
| -rw-r--r-- | AUTHORS | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -214,3 +214,4 @@ Timo Reimann <ttr314@googlemail.com> Sungguk Lim <limasdf@gmail.com> Martin Bednorz <m.s.bednorz@gmail.com> Kamil Jiwa <kamil.jiwa@gmail.com> +Keene Pan <keenepan@linpus.com> |