diff options
author | trchen@chromium.org <trchen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-06 18:56:13 +0000 |
---|---|---|
committer | trchen@chromium.org <trchen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-06 18:56:13 +0000 |
commit | a90fac760d0633fcc57f5d32e1f71281a3559154 (patch) | |
tree | 4870d820a40a682f7344bc6f0e5e6bc755a4ee29 /AUTHORS | |
parent | 95ee38a5ca72e03a8b98cb4961fc41f0614ce421 (diff) | |
download | chromium_src-a90fac760d0633fcc57f5d32e1f71281a3559154.zip chromium_src-a90fac760d0633fcc57f5d32e1f71281a3559154.tar.gz chromium_src-a90fac760d0633fcc57f5d32e1f71281a3559154.tar.bz2 |
Reland 204442 "Split Layer::SetScrollOffset to tw..."
Test in question was disabled and will be updated.
> Revert 204442 "Split Layer::SetScrollOffset to two functions for..."
>
> webkit_unit_tests gets broken after 20442.
> Logs:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/11442
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/4910
>
> > Split Layer::SetScrollOffset to two functions for different use
> >
> > Currently there are two callers to Layer::SetScrollOffset. One is from
> > the Blink ScrollingCoordinator to setup scrolling parameters. The other
> > one is from the threaded compositing commits to apply scroll deltas.
> >
> > After the patch we have Layer::SetScrollOffset for Blink. This version
> > will setNeedsCommit(), but will not notify ScrollableArea (who initiated
> > the scroll anyway) for the change. And a new function
> > Layer::SetScrollOffsetFromImplSide for commits. This version will notify
> > ScrollableArea about the change, but won't setNeedsCommit() for no reason.
> >
> > This fixes a use-after-free bug in Layer::SetScrollOffset, due to
> > ScrollableArea destroying the layer during the process then the layer
> > attempts to setNeedsCommit().
> >
> > R=jamesr@chromium.org
> > BUG=245713,245987
> > NOTRY=true
> > TEST=cc_unittests:LayerTreeHostScrollTestLayerStructureChange.*
> >
> > Review URL: https://chromiumcodereview.appspot.com/15984005
>
> TBR=trchen@chromium.org
>
> Review URL: https://codereview.chromium.org/16460005
TBR=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/16295032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204546 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'AUTHORS')
0 files changed, 0 insertions, 0 deletions