diff options
author | tapted <tapted@chromium.org> | 2014-09-23 06:38:09 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-23 13:38:23 +0000 |
commit | d6828ed750604b5914fa2cc26a739783efa0159b (patch) | |
tree | 07bc46af9c926a7a7cb379c7f54e4362cda77450 /AUTHORS | |
parent | c31b500ace88c6115bbd0b6847c465c44723b4af (diff) | |
download | chromium_src-d6828ed750604b5914fa2cc26a739783efa0159b.zip chromium_src-d6828ed750604b5914fa2cc26a739783efa0159b.tar.gz chromium_src-d6828ed750604b5914fa2cc26a739783efa0159b.tar.bz2 |
Remove StartPageView from being a AppListViewDelegateObserver
It observes OnProfilesChanged, but the set of profiles changing doesn't
affect the start page. However, it probably once helped avoid crashes
when deleting profiles since the AppListViewDelegate would hold on to
the Profile* until the app list was shown again. But that was fixed in
http://crrev.com/291852 (now AppListServiceImpl::DestroyAppList() will
reliably tear down the AppListView if the profile is destroyed, without
having to wait for a ShowAppList().
When regular profile switching occurs (i.e. not when the profile is
being destroyed), the profile currently being used by the
StartPageView is also replaced. That is handled by
AppListMainView::ModelChanged() calling into
ContentsView::InitNamedPages() which makes an entirely new
StartPageView().
BUG=403647
Review URL: https://codereview.chromium.org/589333002
Cr-Commit-Position: refs/heads/master@{#296175}
Diffstat (limited to 'AUTHORS')
0 files changed, 0 insertions, 0 deletions