summaryrefslogtreecommitdiffstats
path: root/DEPS
diff options
context:
space:
mode:
authormark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-21 21:25:09 +0000
committermark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-21 21:25:09 +0000
commit2891238008c68564ba735ae48d0334d1aa8e66f5 (patch)
tree848077a15bce11a76c1fe7b63eeeae9c4253748a /DEPS
parentac9cada590a12e178ae358821b9d9758e847201f (diff)
downloadchromium_src-2891238008c68564ba735ae48d0334d1aa8e66f5.zip
chromium_src-2891238008c68564ba735ae48d0334d1aa8e66f5.tar.gz
chromium_src-2891238008c68564ba735ae48d0334d1aa8e66f5.tar.bz2
Update Breakpad from r627 to r628 to pick up:
Separate the "hello" message from the parameter messages in Inspector::ReadMessages as was done before r627. The "hello" message contains the parameter count and is referenced while the message reader loops through parameter messages. Prior to r627, both messages were named |message|, which was confusing, probably caused a compiler warning, and apparently provided the motivation to share them. This caused the crash inspector to fail to properly collect the parameters. The common failure mode (although others are possible) was for the inspector to attempt tor read more parameter messages than were available, resulting in an IPC timeout and inspector death. No crash report would be written, and the application expecting its crash to be inspected would time out waiting for a response from the inspector and then _exit. Thisis effectively a failure to properly handle crashes. The inner message is reintroduced, and named parameter_message for disambiguation. BUG=49821 TEST= - Crashes catchable by the Mac Breakpad framework. - about:crash and its browser equivalent works and produces crash dumps in ~/Library/Breakpad/Chrome_Mac Review URL: http://codereview.chromium.org/2842063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53244 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'DEPS')
-rw-r--r--DEPS2
1 files changed, 1 insertions, 1 deletions
diff --git a/DEPS b/DEPS
index 4cb896f..69e09f3 100644
--- a/DEPS
+++ b/DEPS
@@ -13,7 +13,7 @@ vars = {
deps = {
"src/breakpad/src":
- "http://google-breakpad.googlecode.com/svn/trunk/src@627",
+ "http://google-breakpad.googlecode.com/svn/trunk/src@628",
"src/build/util/support":
"/trunk/deps/support@20411",