diff options
| author | zhchbin@gmail.com <zhchbin@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-04 05:44:38 +0000 |
|---|---|---|
| committer | zhchbin@gmail.com <zhchbin@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-04 05:44:38 +0000 |
| commit | 639dec9a36f2f9db7de9952133e6c7fe557b4168 (patch) | |
| tree | 723f8d508185e44ff1aeb69c3fcb5a5a0ad63fb9 /LICENSE.chromium_os | |
| parent | 08ac6f9ebc29f5d86df4f5ce9bc5e076ccfe370a (diff) | |
| download | chromium_src-639dec9a36f2f9db7de9952133e6c7fe557b4168.zip chromium_src-639dec9a36f2f9db7de9952133e6c7fe557b4168.tar.gz chromium_src-639dec9a36f2f9db7de9952133e6c7fe557b4168.tar.bz2 | |
Fix issue: when overriding keybinding preferences, should remove the one taken.
Also including the following things:
1. Fix a problem that introduced by my previous CL[0].
In the ExtensionKeybindingRegistry::RemoveExtensionKeybinding, we should break
only when we really find the specified command.
2. Test case for removal of keybinding preference should be platform-specific.
[0]: https://codereview.chromium.org/64273008/
BUG=302437
TEST=interactive_ui_tests --gtest_filter=CommandsApiTest.UpdateKeybindingPrefsTest
TEST=browser_test --gtest_filter=CommandServiceTest.RemoveKeybindingPrefsShouldBePlatformSpecific
TBR=finnur@chromium.org
Review URL: https://codereview.chromium.org/94723008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'LICENSE.chromium_os')
0 files changed, 0 insertions, 0 deletions