diff options
| author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-18 03:29:54 +0000 |
|---|---|---|
| committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-18 03:29:54 +0000 |
| commit | 3e4eb113eeed13cfdd6940b7183f22702e97dd0b (patch) | |
| tree | cc9b51aa6f09c62f8108a29c10c81872b40cedda /PRESUBMIT.py | |
| parent | d6ba5a0be48775567768b6c1699a5b00a5076d00 (diff) | |
| download | chromium_src-3e4eb113eeed13cfdd6940b7183f22702e97dd0b.zip chromium_src-3e4eb113eeed13cfdd6940b7183f22702e97dd0b.tar.gz chromium_src-3e4eb113eeed13cfdd6940b7183f22702e97dd0b.tar.bz2 | |
Remove BUG= and TEST= checks from upload commit presubmit check.
Fix PRESUBMIT.py to exclude Makefile.
BUG=none
TEST=presubmit check is less noisy
Review URL: http://codereview.chromium.org/5976009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 0cff3de..65df224 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -9,10 +9,11 @@ for more details about the presubmit API built into gcl. """ _EXCLUDED_PATHS = ( - r"breakpad[\\\/].*", - r"net/tools/spdyshark/[\\\/].*", - r"skia[\\\/].*", - r"v8[\\\/].*", + r"^breakpad[\\\/].*", + r"^net/tools/spdyshark/[\\\/].*", + r"^skia[\\\/].*", + r"^v8[\\\/].*", + r".*MakeFile$", ) _TEXT_FILES = ( @@ -106,10 +107,6 @@ def _CommonChecks(input_api, output_api): input_api, output_api, source_file_filter=sources)) results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( input_api, output_api, source_file_filter=sources)) - results.extend(input_api.canned_checks.CheckChangeHasBugField( - input_api, output_api)) - results.extend(input_api.canned_checks.CheckChangeHasTestField( - input_api, output_api)) results.extend(input_api.canned_checks.CheckChangeSvnEolStyle( input_api, output_api, source_file_filter=text_files)) results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes( @@ -171,6 +168,10 @@ def CheckChangeOnCommit(input_api, output_api): 'http://build.chromium.org/p/chromium/json/builders?filter=1', 6, IGNORED_BUILDERS)) + results.extend(input_api.canned_checks.CheckChangeHasBugField( + input_api, output_api)) + results.extend(input_api.canned_checks.CheckChangeHasTestField( + input_api, output_api)) return results |