diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-29 20:15:19 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-29 20:15:19 +0000 |
| commit | 839c139ee89128d50d098be9a86d2b584e11ed01 (patch) | |
| tree | 1cf9139c2589457822d52e0a58c57aaae2a7545e /PRESUBMIT.py | |
| parent | 7b025aff7f4a5f513cc93e801a14028abb8582cd (diff) | |
| download | chromium_src-839c139ee89128d50d098be9a86d2b584e11ed01.zip chromium_src-839c139ee89128d50d098be9a86d2b584e11ed01.tar.gz chromium_src-839c139ee89128d50d098be9a86d2b584e11ed01.tar.bz2 | |
Don't let the presubmit check warn about |@interface| in comments in base.
Doesn't catch all /**/ style comments, but in practice we don't use /**/
comments, and when we do, we start every line with a *, and that's caught.
(On the flipside, this doesn't catch "/**/@interface". http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6905134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83578 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index e7ce3c1..e196e32 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -19,7 +19,7 @@ _EXCLUDED_PATHS = ( def _CheckNoInterfacesInBase(input_api, output_api): """Checks to make sure no files in libbase.a have |@interface|.""" - pattern = input_api.re.compile(r'@interface') + pattern = input_api.re.compile(r'^\s*@interface', input_api.re.MULTILINE) files = [] for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile): if (f.LocalPath().find('base/') != -1 and |