diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-15 13:48:33 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-15 13:48:33 +0000 |
| commit | 3afb12a49cd798e51701f265c3466b78236f573f (patch) | |
| tree | d41e262dce40d2103fd695a2e68fc3af88591fd5 /PRESUBMIT.py | |
| parent | 9320a303dc92bb2217b025b113585646dfe804d3 (diff) | |
| download | chromium_src-3afb12a49cd798e51701f265c3466b78236f573f.zip chromium_src-3afb12a49cd798e51701f265c3466b78236f573f.tar.gz chromium_src-3afb12a49cd798e51701f265c3466b78236f573f.tar.bz2 | |
Add rules to exclude files with paths containing /test/, /tool/ and /tools/.
BUG=none
TEST=manually tested by developer
Review URL: http://codereview.chromium.org/7637015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96768 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 515f3d0..63c81aa 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -51,6 +51,7 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): file_inclusion_pattern = r'.+%s' % source_extensions file_exclusion_pattern = (r'.+(_test_support|_(unit|browser|ui|perf)test)%s' % source_extensions) + path_exclusion_pattern = r'.*[/\\](test|tool(s)?)[/\\].*' base_function_pattern = r'ForTest(ing)?|for_test(ing)?' inclusion_pattern = input_api.re.compile(r'(%s)\s*\(' % base_function_pattern) @@ -59,8 +60,8 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): base_function_pattern, base_function_pattern)) def FilterFile(affected_file): - black_list = ((file_exclusion_pattern, ) + _EXCLUDED_PATHS + - input_api.DEFAULT_BLACK_LIST) + black_list = ((file_exclusion_pattern, path_exclusion_pattern, ) + + _EXCLUDED_PATHS + input_api.DEFAULT_BLACK_LIST) return input_api.FilterSourceFile( affected_file, white_list=(file_inclusion_pattern, ), |