diff options
| author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-22 02:16:07 +0000 |
|---|---|---|
| committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-22 02:16:07 +0000 |
| commit | 7c5ae13dbcbbb142c1ba634a291fb854f6bfb652 (patch) | |
| tree | ed6ac23a33da893cb253bf4dca9d7f82fd5b81dd /PRESUBMIT.py | |
| parent | e1e8fe911abb5077dc3522d1935bdc27df36216a (diff) | |
| download | chromium_src-7c5ae13dbcbbb142c1ba634a291fb854f6bfb652.zip chromium_src-7c5ae13dbcbbb142c1ba634a291fb854f6bfb652.tar.gz chromium_src-7c5ae13dbcbbb142c1ba634a291fb854f6bfb652.tar.bz2 | |
Remove pending builds check, it's going to interfere with the commit queue
and slows down presubmit without much advantage anymore.
Remove input_api.json check, it cannot be None anymore.
R=nsylvain@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/6896011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82611 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 6b08653..e7ce3c1 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -98,17 +98,6 @@ def CheckChangeOnUpload(input_api, output_api): def CheckChangeOnCommit(input_api, output_api): results = [] - if not input_api.json: - results.append(output_api.PresubmitNotifyResult( - 'You don\'t have json nor simplejson installed.\n' - ' This is a warning that you will need to upgrade your python ' - 'installation.\n' - ' This is no big deal but you\'ll eventually need to ' - 'upgrade.\n' - ' How? Easy! You can do it right now and shut me off! Just:\n' - ' del depot_tools\\python.bat\n' - ' gclient\n' - ' Thanks for your patience.')) results.extend(_CommonChecks(input_api, output_api)) # TODO(thestig) temporarily disabled, doesn't work in third_party/ #results.extend(input_api.canned_checks.CheckSvnModifiedDirectories( @@ -122,20 +111,6 @@ def CheckChangeOnCommit(input_api, output_api): output_api, 'http://codereview.chromium.org', ('win', 'linux', 'mac'), 'tryserver@chromium.org')) - # These builders are just too slow. - IGNORED_BUILDERS = [ - 'Chromium XP', - 'Chromium Mac', - 'Chromium Arm (dbg)', - 'Chromium Linux', - 'Chromium Linux x64', - ] - results.extend(input_api.canned_checks.CheckBuildbotPendingBuilds( - input_api, - output_api, - 'http://build.chromium.org/p/chromium/json/builders?filter=1', - 6, - IGNORED_BUILDERS)) results.extend(input_api.canned_checks.CheckChangeHasBugField( input_api, output_api)) results.extend(input_api.canned_checks.CheckChangeHasTestField( |