Add a presubmit check that catches iostream usage in header files.

BUG=94794
TEST=none

Review URL: http://codereview.chromium.org/7792076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99291 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 22 insertions, 0 deletions

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 63c81aa..1f51057 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -89,6 +89,27 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
     return []
 
 
+def _CheckNoIOStreamInHeaders(input_api, output_api):
+  """Checks to make sure no .h files include <iostream>."""
+  files = []
+  pattern = input_api.re.compile(r'^#include\s*<iostream>',
+                                 input_api.re.MULTILINE)
+  for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
+    if not f.LocalPath().endswith('.h'):
+      continue
+    contents = input_api.ReadFile(f)
+    if pattern.search(contents):
+      files.append(f)
+
+  if len(files):
+    return [ output_api.PresubmitError(
+        'Do not #include <iostream> in header files, since it inserts static ' +
+        'initialization into every file including the header. Instead, ' +
+        '#include <ostream>. See http://crbug.com/94794',
+        files) ]
+  return []
+
+
 def _CommonChecks(input_api, output_api):
   """Checks common to both upload and commit."""
   results = []
@@ -98,6 +119,7 @@ def _CommonChecks(input_api, output_api):
   results.extend(_CheckAuthorizedAuthor(input_api, output_api))
   results.extend(
     _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
+  results.extend(_CheckNoIOStreamInHeaders(input_api, output_api))
   return results