diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-10 23:09:49 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-10 23:09:49 +0000 |
| commit | 9c501313373c729357c88c9cc9a0ef1cf6295323 (patch) | |
| tree | 377c67555cd091a1812667dba9714dccefdb55d4 /PRESUBMIT.py | |
| parent | 8049797524ff328452f1460e18b32592f2ac6de6 (diff) | |
| download | chromium_src-9c501313373c729357c88c9cc9a0ef1cf6295323.zip chromium_src-9c501313373c729357c88c9cc9a0ef1cf6295323.tar.gz chromium_src-9c501313373c729357c88c9cc9a0ef1cf6295323.tar.bz2 | |
Presubmit change to add android trybots when needed.
Also add warning in android_all.gyp that extra targets in 'all' can
have a significant impact on the try load so coordinate appropriately.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9360028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121560 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index aa79141..fd1df32 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -342,4 +342,17 @@ def GetPreferredTrySlaves(project, change): aura_re = '_aura[^/]*[.][^/]*' if any(re.search(aura_re, f.LocalPath()) for f in change.AffectedFiles()): preferred.append('linux_chromeos') + # For bringup (staging of upstream work) we must be careful to not + # overload Android infrastructure. Keeping Android try decisions in a + # single location (instead of adding conditionals in base/, net/, ...) + # will help us avoid doing so. For example, we are starting off with + # 2 trybots (compared against ~45 for Mac and Linux). + # If any file matches something compiled on the main waterfall + # android builder, use the android try server. + android_re_list = ('^base/', '^ipc/', '^net/', '^sql/', '^jingle/', + '^build/common.gypi$') + for f in change.AffectedFiles(): + if any(re.search(r, f.LocalPath()) for r in android_re_list): + preferred.append('android') + break return preferred |