diff options
| author | kuchhal@chromium.org <kuchhal@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-12 21:58:31 +0000 |
|---|---|---|
| committer | kuchhal@chromium.org <kuchhal@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-12 21:58:31 +0000 |
| commit | 6cd1437324ac16c4bf43d4cdc82644687cd07f2c (patch) | |
| tree | 561c14820ba8a25eb72a32bb2e02ca31127c38fc /PRESUBMIT.py | |
| parent | b39881224053fa1000f77b2543af51afda17f0cf (diff) | |
| download | chromium_src-6cd1437324ac16c4bf43d4cdc82644687cd07f2c.zip chromium_src-6cd1437324ac16c4bf43d4cdc82644687cd07f2c.tar.gz chromium_src-6cd1437324ac16c4bf43d4cdc82644687cd07f2c.tar.bz2 | |
Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 2 of 2).
BUG=11287
TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.
Review URL: http://codereview.chromium.org/115261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15906 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rwxr-xr-x | PRESUBMIT.py | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index d73d566..c2f0b77 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -40,14 +40,18 @@ def ReadFile(path): def CheckChangeOnUpload(input_api, output_api): # TODO(maruel): max_cols is temporarily disabled. Reenable once the source # tree is in better shape. - return LocalChecks(input_api, output_api, max_cols=0) + return (LocalChecks(input_api, output_api, max_cols=0) + + input_api.canned_checks.CheckChangeHasBugField(input_api, output_api) + + input_api.canned_checks.CheckChangeHasTestField(input_api, output_api)) def CheckChangeOnCommit(input_api, output_api): # TODO(maruel): max_cols is temporarily disabled. Reenable once the source # tree is in better shape. return (LocalChecks(input_api, output_api, max_cols=0) + - input_api.canned_checks.CheckDoNotSubmit(input_api, output_api)) + input_api.canned_checks.CheckDoNotSubmit(input_api, output_api) + + input_api.canned_checks.CheckChangeHasBugField(input_api, output_api) + + input_api.canned_checks.CheckChangeHasTestField(input_api, output_api)) def LocalChecks(input_api, output_api, max_cols=80): |