diff options
| author | achuith@chromium.org <achuith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-06 09:44:01 +0000 |
|---|---|---|
| committer | achuith@chromium.org <achuith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-06 09:44:01 +0000 |
| commit | 9eb52cf9acd967a437d11a8c5067c0e470538ba9 (patch) | |
| tree | e8ec1121cb2967d04b56c78fcdb8381533a660d5 /PRESUBMIT.py | |
| parent | b3a791ffa733bd6fa5a2d5e3bb5d40e7d9995ad1 (diff) | |
| download | chromium_src-9eb52cf9acd967a437d11a8c5067c0e470538ba9.zip chromium_src-9eb52cf9acd967a437d11a8c5067c0e470538ba9.tar.gz chromium_src-9eb52cf9acd967a437d11a8c5067c0e470538ba9.tar.bz2 | |
DriveResourceMetadata::MoveEntryToDirectory cleanup.
* DriveResourceMetadata::MoveEntryToDirectory now takes a FilePath instead of a DriveEntry*.
* DriveResourceMetadata has a new public method RenameEntry, which does what DriveFileSystem::RenameEntryLocally used to do. RenameEntryLocally now simply calls DriveResourceMetadata::RenameEntry.
* DriveFileSystem's MoveEntryToRootDirectoryLocally and OnMoveEntryFromRootDirectoryCompletely are eliminated in favor of one method MoveEntryToDirectory. Both these methods did very similar things.
* DriveResourceMetadataTest introduced because MoveEntryToDirectory can no longer be used. This class is a friend of DriveDirectory, and we directly use AddEntry instead. This also eliminates a bunch of repetitive initialization code. All TEST are now TEST_F.
* DBTest has been rewritten a bit. Get rid of VerifyDirectoryService. We only check for children of drive/dir3 to ensure that the filesystem has been properly initialized from the database.
* DriveResourceMetadata::InitFromDB's callback may not be null.
BUG=142048
TEST=unit tests.
Review URL: https://chromiumcodereview.appspot.com/10914059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155159 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
0 files changed, 0 insertions, 0 deletions