summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
diff options
context:
space:
mode:
authoradamk@chromium.org <adamk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-03 23:19:15 +0000
committeradamk@chromium.org <adamk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-03 23:19:15 +0000
commit79150720f89cf08448756451846ec35609d9b650 (patch)
tree596d34c4a1bb2bae6bac50ebd536653402c3191b /PRESUBMIT.py
parent4120bcf3e2f6b4e4532672821b4f10ea0e4f9e0c (diff)
downloadchromium_src-79150720f89cf08448756451846ec35609d9b650.zip
chromium_src-79150720f89cf08448756451846ec35609d9b650.tar.gz
chromium_src-79150720f89cf08448756451846ec35609d9b650.tar.bz2
Skip _CheckFilePermissions check on Windows
Executable bits are wonky on Windows, so checking them doesn't get us anything and incorrectly disallows uploading of, e.g., python scripts. R=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/142973008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248605 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r--PRESUBMIT.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index b5aefd3..cd5baaa 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -522,6 +522,8 @@ def _CheckUnwantedDependencies(input_api, output_api):
def _CheckFilePermissions(input_api, output_api):
"""Check that all files have their permissions properly set."""
+ if input_api.platform == 'win32':
+ return []
args = [sys.executable, 'tools/checkperms/checkperms.py', '--root',
input_api.change.RepositoryRoot()]
for f in input_api.AffectedFiles():