diff options
| author | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-04 18:43:43 +0000 |
|---|---|---|
| committer | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-04 18:43:43 +0000 |
| commit | ec5b3f085f3ee1c50d16c79b32bc2bcfe1cdc2c8 (patch) | |
| tree | 262cef17f5da2a73224e522b1fe907e316c61dc5 /PRESUBMIT.py | |
| parent | 159005d55696fa6e626f8734e6da8432ba521c49 (diff) | |
| download | chromium_src-ec5b3f085f3ee1c50d16c79b32bc2bcfe1cdc2c8.zip chromium_src-ec5b3f085f3ee1c50d16c79b32bc2bcfe1cdc2c8.tar.gz chromium_src-ec5b3f085f3ee1c50d16c79b32bc2bcfe1cdc2c8.tar.bz2 | |
Make sure no new v8::Extensions are added.
New code should use gin::Wrappable<> instead
BUG=334679
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/225863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261804 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 8c27266..71e3a28 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -234,6 +234,15 @@ _BANNED_CPP_FUNCTIONS = ( r'^ppapi[\\\/]tests[\\\/]test_broker\.cc$', ), ), + ( + r'/v8::Extension\(', + ( + 'Do not introduce new v8::Extensions into the code base, use', + 'gin::Wrappable instead. See http://crbug.com/334679', + ), + True, + (), + ), ) |