diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-22 02:28:51 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-22 02:28:51 +0000 |
| commit | e71c608d20127e55904688eb08037ed0ea64bc7c (patch) | |
| tree | 2decc640cdc4426f625c21117cb5011c586830a8 /PRESUBMIT.py | |
| parent | 7ce6f93ef80a04d7de77a8516c05a648037d8005 (diff) | |
| download | chromium_src-e71c608d20127e55904688eb08037ed0ea64bc7c.zip chromium_src-e71c608d20127e55904688eb08037ed0ea64bc7c.tar.gz chromium_src-e71c608d20127e55904688eb08037ed0ea64bc7c.tar.bz2 | |
Fix _CheckAddedDepsHaveTargetApprovals for the case where no owner has been specified.
TBR=maruel@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/15491008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201426 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 3418265..1253c4a0 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -774,7 +774,9 @@ def _CheckAddedDepsHaveTargetApprovals(input_api, output_api): owner_email = owner_email or input_api.change.author_email - reviewers_plus_owner = set([owner_email]).union(reviewers) + reviewers_plus_owner = reviewers + if owner_email: + reviewers_plus_owner = set([owner_email]).union(reviewers) missing_files = owners_db.files_not_covered_by(virtual_depended_on_files, reviewers_plus_owner) unapproved_dependencies = ["'+%s'," % path[:-len('/DEPS')] |