diff options
author | mostynb <mostynb@opera.com> | 2014-10-22 06:21:29 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-22 13:21:49 +0000 |
commit | 5a73a5d37237fcf25bb05571a314193188600c65 (patch) | |
tree | 44935f43ad9a127cc49db1901fb316f73b80b25b /PRESUBMIT.py | |
parent | fd4440e67bd92bd7b94d6e57ee8b445aebcda15e (diff) | |
download | chromium_src-5a73a5d37237fcf25bb05571a314193188600c65.zip chromium_src-5a73a5d37237fcf25bb05571a314193188600c65.tar.gz chromium_src-5a73a5d37237fcf25bb05571a314193188600c65.tar.bz2 |
remove obsolete OVERRIDE/FINAL presubmit checks
BUG=417463
Review URL: https://codereview.chromium.org/655693003
Cr-Commit-Position: refs/heads/master@{#300675}
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r-- | PRESUBMIT.py | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 6ee3db6..3d2d077 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -1282,22 +1282,6 @@ def _CheckNoDeprecatedJS(input_api, output_api): return results -def _CheckForOverrideAndFinalRules(input_api, output_api): - """Checks for final and override used as per C++11""" - problems = [] - for f in input_api.AffectedFiles(): - if (f.LocalPath().endswith(('.cc', '.cpp', '.h', '.mm'))): - for line_num, line in f.ChangedContents(): - if (input_api.re.search(r'\b(FINAL|OVERRIDE)\b', line)): - problems.append(' %s:%d' % (f.LocalPath(), line_num)) - - if not problems: - return [] - return [output_api.PresubmitError('Use C++11\'s |final| and |override| ' - 'rather than FINAL and OVERRIDE.', - problems)] - - def _CommonChecks(input_api, output_api): """Checks common to both upload and commit.""" results = [] @@ -1340,7 +1324,6 @@ def _CommonChecks(input_api, output_api): results.extend(_CheckNoDeprecatedJS(input_api, output_api)) results.extend(_CheckParseErrors(input_api, output_api)) results.extend(_CheckForIPCRules(input_api, output_api)) - results.extend(_CheckForOverrideAndFinalRules(input_api, output_api)) if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()): results.extend(input_api.canned_checks.RunUnitTestsInDirectory( |