diff options
author | thakis <thakis@chromium.org> | 2015-02-23 09:00:37 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-02-23 17:01:24 +0000 |
commit | 4f02f4cd6c8b9087ecd286c905b15e253d88d82f (patch) | |
tree | ddddecc466cd4ac08007913660bddebae1c3f77f /PRESUBMIT.py | |
parent | 6377bfd717ccf6488462d6d22248f28918c247b5 (diff) | |
download | chromium_src-4f02f4cd6c8b9087ecd286c905b15e253d88d82f.zip chromium_src-4f02f4cd6c8b9087ecd286c905b15e253d88d82f.tar.gz chromium_src-4f02f4cd6c8b9087ecd286c905b15e253d88d82f.tar.bz2 |
Make `git cl try` to the same as hitting cq (except for presubmit).
PRESUBMIT.py used to contain a handwritten list of bots to trigger on
`git cl try`. It was always out of sync with what the cq did.
https://codereview.chromium.org/823823002 awesomely made `git cl try` do
the same thing as the commit queue, but it kept a few special-case rules around.
It's better to not have these special cases: Once the developer hits cq, all
the "intelligently" skipped bots need to be run anyways. More importantly,
there should be only one system to decide what to run and it should be
identical for cq and `git cl try`. Currently, we think this system is the
`analyze` step, and it does a decent job of that already.
BUG=none (but made possible by 443613)
Review URL: https://codereview.chromium.org/921323003
Cr-Commit-Position: refs/heads/master@{#317597}
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r-- | PRESUBMIT.py | 29 |
1 files changed, 0 insertions, 29 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index c49ccd0c4..5507aa1 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -1744,29 +1744,6 @@ def GetPreferredTryMasters(project, change): import re files = change.LocalPaths() - if not files or all(re.search(r'[\\\/]OWNERS$', f) for f in files): - return {} - - if all(re.search(r'\.(m|mm)$|(^|[\\\/_])mac[\\\/_.]', f) for f in files): - return GetDefaultTryConfigs([ - 'mac_chromium_compile_dbg_ng', - 'mac_chromium_rel_ng', - ]) - if all(re.search('(^|[/_])win[/_.]', f) for f in files): - return GetDefaultTryConfigs([ - 'win8_chromium_rel', - 'win_chromium_rel_ng', - 'win_chromium_x64_rel_ng', - ]) - if all(re.search(r'(^|[\\\/_])android[\\\/_.]', f) and - not re.search(r'(^|[\\\/_])devtools[\\\/_.]', f) for f in files): - return GetDefaultTryConfigs([ - 'android_aosp', - 'android_rel_tests_recipe', - ]) - if all(re.search(r'[\\\/_]ios[\\\/_.]', f) for f in files): - return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) - import os import json with open(os.path.join( @@ -1787,10 +1764,4 @@ def GetPreferredTryMasters(project, change): if 'presubmit' in builder: builders[master].pop(builder) - # Match things like path/aura/file.cc and path/file_aura.cc. - # Same for chromeos. - if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files): - tryserver_linux = builders.setdefault('tryserver.chromium.linux', {}) - tryserver_linux['linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests'] - return builders |