diff options
| author | b.kelemen@samsung.com <b.kelemen@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-07 23:19:54 +0000 |
|---|---|---|
| committer | b.kelemen@samsung.com <b.kelemen@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-07 23:19:54 +0000 |
| commit | 4436c9e4f278db827b4e0b392f214ed81f837d79 (patch) | |
| tree | 4d55a169974ebe74cd6c4f16127761229b000e2a /PRESUBMIT.py | |
| parent | ac91eda402ff923c04f5f4c5b606e4f4452e1de4 (diff) | |
| download | chromium_src-4436c9e4f278db827b4e0b392f214ed81f837d79.zip chromium_src-4436c9e4f278db827b4e0b392f214ed81f837d79.tar.gz chromium_src-4436c9e4f278db827b4e0b392f214ed81f837d79.tar.bz2 | |
Include order check should work better for files containing uncheckable includes
Currently as soon as we see an uncheckable include (like ipc/*macros.h or
windows.h) we stop checking the file. Instead we should just skip that line
and continue checking.
Review URL: https://codereview.chromium.org/105633012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243427 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 6a77b9f..aa8d97f 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -667,7 +667,7 @@ def _CheckIncludeOrderInFile(input_api, f, changed_linenums): for line in contents[line_num:]: line_num += 1 if uncheckable_includes_pattern.match(line): - return [] + continue if if_pattern.match(line): scopes.append(current_scope) current_scope = [] |