diff options
| author | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-30 20:07:54 +0000 |
|---|---|---|
| committer | erg@chromium.org <erg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-30 20:07:54 +0000 |
| commit | e8df48fa37b515323291bc61959b27c8cb696064 (patch) | |
| tree | fecd4e3047ded07779e519f612af368a712937bc /PRESUBMIT.py | |
| parent | 0e994a093d5bd3b8d2531c8e7d8a0f6c5ff46cb3 (diff) | |
| download | chromium_src-e8df48fa37b515323291bc61959b27c8cb696064.zip chromium_src-e8df48fa37b515323291bc61959b27c8cb696064.tar.gz chromium_src-e8df48fa37b515323291bc61959b27c8cb696064.tar.bz2 | |
Run cros_x86 trybots on changes to ^(base|build|chromeos).*\.gypi?$.
Since the full chromeos builders are sensitive to high level gypi
changes, make sure to do full tryjobs on them in addition to the faster
linux_chromeos bots when gyp files change.
BUG=none
R=maruel@chromium.org, phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/24366005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226033 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index cf9941e..632833f 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -1056,6 +1056,14 @@ def GetPreferredTrySlaves(project, change): if any(re.search('[/_](aura|chromeos)', f) for f in files): trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan'] + # If there are gyp changes to base, build, or chromeos, run a full cros build + # in addition to the shorter linux_chromeos build. Changes to high level gyp + # files have a much higher chance of breaking the cros build, which is + # differnt from the linux_chromeos build that most chrome developers test + # with. + if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): + trybots += ['cros_x86'] + # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it # unless they're .gyp(i) files as changes to those files can break the gyp # step on that bot. |