diff options
author | bcwhite@chromium.org <bcwhite@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-18 23:16:12 +0000 |
---|---|---|
committer | bcwhite@chromium.org <bcwhite@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-18 23:16:12 +0000 |
commit | 4de7526e6caf6695839823fc2524fcfdb6d44af7 (patch) | |
tree | fa258774e347c496bd94b02f383ea492893c96e2 /PRESUBMIT.py | |
parent | fddfb023161a0ca56d6c5762490da09af5cb2a57 (diff) | |
download | chromium_src-4de7526e6caf6695839823fc2524fcfdb6d44af7.zip chromium_src-4de7526e6caf6695839823fc2524fcfdb6d44af7.tar.gz chromium_src-4de7526e6caf6695839823fc2524fcfdb6d44af7.tar.bz2 |
Run all flag-checks for new-profile-managment et al through common functions for future Finch integration.
In order to do tests and a safe, controlled roll-out of Chrome's new profile management, we're going to enable it using a Finch experiment. The current tests of the existing command-line flags all need to be routed through common functions in order to override these settings if a Finch experiment is set.
Affected flags are:
--new-profile-management
--enable-inline-signin
--google-profile-info
Note that there existed a function to test for NewProfileManagement but it was not in a good place for general testing and definitely not for other flags so it has been extracted as well.
BUG=324046
Review URL: https://codereview.chromium.org/108803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241698 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r-- | PRESUBMIT.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index f7b8d8a..573a2c7 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -868,6 +868,8 @@ def _CheckSpamLogging(input_api, output_api): (r"^base[\\\/]logging\.h$", r"^chrome[\\\/]app[\\\/]chrome_main_delegate\.cc$", r"^chrome[\\\/]browser[\\\/]chrome_browser_main\.cc$", + r"^chrome[\\\/]browser[\\\/]ui[\\\/]startup[\\\/]" + r"startup_browser_creator\.cc$", r"^chrome[\\\/]installer[\\\/]setup[\\\/].*", r"^chrome[\\\/]renderer[\\\/]extensions[\\\/]" r"logging_native_handler\.cc$", |